Bug 403353 - The notification indicator is not zoomed identically with the cropped icon
Summary: The notification indicator is not zoomed identically with the cropped icon
Status: RESOLVED FIXED
Alias: None
Product: lattedock
Classification: Plasma
Component: application (show other bugs)
Version: git (master)
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Michail Vourlakos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-18 12:10 UTC by Viorel-Cătălin Răpițeanu
Modified: 2019-01-19 20:29 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Panel configuration settings (556.57 KB, image/png)
2019-01-18 12:10 UTC, Viorel-Cătălin Răpițeanu
Details
Panel containing an application with a notification indicator (90.89 KB, image/png)
2019-01-18 12:11 UTC, Viorel-Cătălin Răpițeanu
Details
The panel zoomed on the application with the mentioned notification (130.67 KB, image/png)
2019-01-18 12:11 UTC, Viorel-Cătălin Răpițeanu
Details
Layout in question (2.33 KB, text/plain)
2019-01-19 19:33 UTC, Viorel-Cătălin Răpițeanu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Viorel-Cătălin Răpițeanu 2019-01-18 12:10:22 UTC
Created attachment 117534 [details]
Panel configuration settings

SUMMARY


STEPS TO REPRODUCE
1. Start an application that has at least 1 notification indicator
2. Add zoom effect to the panel (see attached settings attachment image)
3. Place the cursor over the icon with the notification

OBSERVED RESULT
The icon is zoomed differently than the notification indicator. (see attached image)

EXPECTED RESULT
The icon and the notification indicator should be zoomed identically.

SOFTWARE/OS VERSIONS
Monitor resolution: 3840 x 2160
Linux/KDE Plasma: 5.14.90
KDE Plasma Version: 5.14.90
KDE Frameworks Version: 5.54.0
Qt Version: 5.12.0-3
Comment 1 Viorel-Cătălin Răpițeanu 2019-01-18 12:11:20 UTC
Created attachment 117535 [details]
Panel containing an application with a notification indicator
Comment 2 Viorel-Cătălin Răpițeanu 2019-01-18 12:11:57 UTC
Created attachment 117536 [details]
The panel zoomed on the application with the mentioned notification
Comment 3 Michail Vourlakos 2019-01-18 12:23:18 UTC
I tried to reproduce but I couldnt...

1. please try to reproduce with:

"qdbus org.kde.lattedock /Latte updateDockItemBadge dolphin 2"


2. Have you set any screen scale factor?
3. Have you enabled any PLASMA_USE_QT_SCALING variable for your system? you can check this with "env" command
Comment 4 Viorel-Cătălin Răpițeanu 2019-01-18 17:26:28 UTC
> 1. please try to reproduce with:
> "qdbus org.kde.lattedock /Latte updateDockItemBadge dolphin 2"
The application icon is changing correctly when zoomed if the notification it's being hardcoded like this.

> 2. Have you set any screen scale factor?
No. The output scale factor is 1.

> 3. Have you enabled any PLASMA_USE_QT_SCALING variable for your system? you can check this with "env" command
The only Qt scalling in my env is 'QT_AUTO_SCREEN_SCALE_FACTOR=0'. Nothing for Plasma.
Comment 5 Michail Vourlakos 2019-01-19 15:59:39 UTC
(In reply to Viorel-Cătălin Răpițeanu from comment #4)
> > 1. please try to reproduce with:
> > "qdbus org.kde.lattedock /Latte updateDockItemBadge dolphin 2"
> The application icon is changing correctly when zoomed if the notification
> it's being hardcoded like this.
> 

1. please try with latest master, I tried to fix the issue even though I can not reproduce
2. If the problem persists please make some screenshots showing the issue for no zoomed task and for zoomed task, or you can make a video that can you share through google drive or something relevant but not through youtube because of bad marketing.
Comment 6 Viorel-Cătălin Răpițeanu 2019-01-19 16:33:35 UTC
> 1. please try with latest master, I tried to fix the issue even though I can not reproduce
I've got the master branch since I needed the fix you pushed today for application switching on 5.14.90.

> 2. If the problem persists please make some screenshots showing the issue for no zoomed task and for zoomed task, or you can make a video that can you share through google drive or something relevant but not through youtube because of bad marketing.
Done. The video can be found at: https://drive.google.com/drive/folders/1INi2LNWjuWTQe1hYr6QgMbTHO8V7KUxz
Comment 7 Michail Vourlakos 2019-01-19 16:52:14 UTC
(In reply to Viorel-Cătălin Răpițeanu from comment #6)
> > 1. please try with latest master, I tried to fix the issue even though I can not reproduce
> I've got the master branch since I needed the fix you pushed today for
> application switching on 5.14.90.
> 

can you test which is the commit you are using? because the one I am mentioning was uploaded just one-hour before from now
Comment 8 Viorel-Cătălin Răpițeanu 2019-01-19 16:57:48 UTC
Name: plasma 5.15 fixes for VirtualDesktops
SHA1: 2794de1f7347ee45d104af95a40d9daf1c72b1d1
Comment 9 Michail Vourlakos 2019-01-19 17:00:10 UTC
fixed with: https://phabricator.kde.org/R878:ad3b5abeaf0b98f0dab974496efec9a4ffabde45
Comment 10 Michail Vourlakos 2019-01-19 17:02:16 UTC
(In reply to Viorel-Cătălin Răpițeanu from comment #8)
> Name: plasma 5.15 fixes for VirtualDesktops
> SHA1: 2794de1f7347ee45d104af95a40d9daf1c72b1d1

you need e6192a084c9b30d507aef382af      "update badge mask for value changes"
which is later
Comment 11 Viorel-Cătălin Răpițeanu 2019-01-19 17:07:51 UTC
You are right. I've recompiled the latest version, but the issue is still reproducing.

Name: enhance background solidness when touching window
SHA1: ad3b5abeaf0b98f0dab974496efec9a4ffabde45
Comment 12 Michail Vourlakos 2019-01-19 17:34:18 UTC
(In reply to Viorel-Cătălin Răpițeanu from comment #6)
> > 1. please try with latest master, I tried to fix the issue even though I can not reproduce
> I've got the master branch since I needed the fix you pushed today for
> application switching on 5.14.90.
> 
> > 2. If the problem persists please make some screenshots showing the issue for no zoomed task and for zoomed task, or you can make a video that can you share through google drive or something relevant but not through youtube because of bad marketing.
> Done. The video can be found at:
> https://drive.google.com/drive/folders/1INi2LNWjuWTQe1hYr6QgMbTHO8V7KUxz

I need access for this
Comment 13 Viorel-Cătălin Răpițeanu 2019-01-19 17:43:29 UTC
Sorry about that. You should be able to see it now.
Comment 14 Michail Vourlakos 2019-01-19 18:08:56 UTC
I still can't, there is an option to everyone to see the video if he has a shared link for it
Comment 15 Viorel-Cătălin Răpițeanu 2019-01-19 18:11:46 UTC
Please try again.
Comment 16 Michail Vourlakos 2019-01-19 18:36:26 UTC
Ok I watched it, can you send your layout file?
Comment 17 Viorel-Cătălin Răpițeanu 2019-01-19 19:33:10 UTC
Created attachment 117561 [details]
Layout in question

Attached the layout in question.
Comment 18 Michail Vourlakos 2019-01-19 20:20:57 UTC
Git commit 6c09418aa86199941568d112fa185aa434c9196f by Michail Vourlakos.
Committed on 19/01/2019 at 20:15.
Pushed by mvourlakos into branch 'master'.

update badges mask in live mode at all cases

M  +1    -21   plasmoid/package/contents/ui/task/TaskIconItem.qml
M  +0    -4    plasmoid/package/contents/ui/task/TaskProgressOverlay.qml

https://commits.kde.org/latte-dock/6c09418aa86199941568d112fa185aa434c9196f
Comment 19 Viorel-Cătălin Răpițeanu 2019-01-19 20:29:11 UTC
Looks like everything is working as expected. I believe that this ticket can now be closed. Thanks!