Bug 403334 - Can only change Desktop Layout / Wallpaper Plugin via MouseWheel
Summary: Can only change Desktop Layout / Wallpaper Plugin via MouseWheel
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Unclassified
Component: Desktop Containment (show other bugs)
Version: 5.14.90
Platform: Neon Packages Linux
: NOR normal
Target Milestone: 1.0
Assignee: Sebastian Kügler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-18 00:06 UTC by Chris Holland
Modified: 2019-01-18 00:34 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Holland 2019-01-18 00:06:29 UTC
There's a bug when changing Wallpaper Plugin. Left Clicking to open the ComboBox's drop down menu, then left clicking a different plugin will not switch the GUI. Scrolling over the ComboBox works though.

Eg: https://www.youtube.com/watch?v=5S3_OsyJkiw

There was a Kirigami.FormLayout + QtQuickControl2 patch that changed QtControls1.ComboBox.onCurrentIndexChanged
* https://github.com/KDE/plasma-desktop/commits/master/desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml
* https://github.com/KDE/plasma-desktop/commit/c2640f83f1077365cd7f87ca2adbfbfb12cf4da7#diff-95d96a95e58373ce46189786eca598f8L144

to QtControls2.ComboBox.onActivated
* https://github.com/KDE/plasma-desktop/commit/c2640f83f1077365cd7f87ca2adbfbfb12cf4da7#diff-95d96a95e58373ce46189786eca598f8R108

I also noticed the CombBox no longer updates when a wallpaper plugin is installed which https://phabricator.kde.org/D15178 added.

The "Layout: Folder View" => "Layout: Desktop" ComboBox also displays this bug.

The Image wallpaper plugin's "Scaled and Cropped" ComboBox is still using QtQuickControl1.onCurrentIndexChanged so it does not have this bug.
* https://github.com/KDE/plasma-workspace/blame/master/wallpapers/image/imagepackage/contents/ui/config.qml#L91

Neon's gitunstable ISO has Qt 5.11.2

QtQuickControls2 ComboBox
* https://doc.qt.io/qt-5.11/qml-qtquick-controls2-combobox.html
Comment 1 David Edmundson 2019-01-18 00:17:45 UTC
There was a bug in QQC2 combobox with the desktop theme. Should be fixed.
Comment 2 David Edmundson 2019-01-18 00:21:52 UTC
581b140c8b81096f40ddebd84b8b2fbc327b616d in qqc2-desktop-style.
Comment 3 Chris Holland 2019-01-18 00:34:58 UTC
https://github.com/KDE/qqc2-desktop-style/commit/581b140c8b81096f40ddebd84b8b2fbc327b616d

I can confirm that Neon's
/usr/lib/x86_64-linux-gnu/qt5/qml/QtQuick/Controls.2/org.kde.desktop/ComboBox.qml

is using `model` on line 72 + 210 instead of `delegateModel`.

After modifying the file and restarting plasmashell, the bug was fixed. :)