Bug 403307 - New virtual desktop KCM: virtual desktops names are not updated immediately after editing
Summary: New virtual desktop KCM: virtual desktops names are not updated immediately a...
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-17 13:29 UTC by Patrick Silva
Modified: 2019-02-14 18:34 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2019-01-17 13:29:11 UTC
STEPS TO REPRODUCE
1. search for "virtual desktops" kcm in the apps launcher and open it
2. hover over some virtual desktop, click "Rename" button in the right side
3. edit the virtual desktop name, click "ok" button
4. right click some entry in the plasma panel, hover over "Move to desktop"

OBSERVED RESULT
virtual desktop renamed in the steps above is listed with the old name

EXPECTED RESULT
new desktop name appears in "Move to desktop" submenu

SOFTWARE/OS VERSIONS
Operating System: KDE neon Developer Edition
KDE Plasma Version: 5.14.80
KDE Frameworks Version: 5.54.0
Qt Version: 5.11.2


ADDITIONAL INFORMATION
virtual desktop name is updated in "Move to desktop" submenu after restart plasma session
Comment 1 Kai Uwe Broulik 2019-01-17 15:35:29 UTC
Did you Apply your changes?
Comment 2 Kai Uwe Broulik 2019-01-17 15:35:38 UTC
Ah, nevermind, you clicked "ok" :)
Comment 3 Vlad Zahorodnii 2019-01-24 16:38:34 UTC
Git commit 8fd0418187484673e6682b96e93850d0cc1553a5 by Vlad Zagorodniy.
Committed on 24/01/2019 at 16:30.
Pushed by vladz into branch 'Plasma/5.15'.

Keep _NET_DESKTOP_NAMES in sync

Summary:
We have to connect to nameChanged even if m_rootInfo is not set yet,
otherwise names in _NET_DESKTOP_NAMES won't be kept in sync if
a virtual desktop is renamed.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D18503

M  +7    -7    virtualdesktops.cpp

https://commits.kde.org/kwin/8fd0418187484673e6682b96e93850d0cc1553a5