Bug 403295 - Bookmark icon over dark background almost invisible
Summary: Bookmark icon over dark background almost invisible
Status: RESOLVED FIXED
Alias: None
Product: frameworks-ktexteditor
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: HI normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-17 07:30 UTC by Gabriele Menna
Modified: 2019-05-01 02:27 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
a screenshot of a pretty invisible bookmark icon over dark background (4.15 KB, image/png)
2019-01-17 07:30 UTC, Gabriele Menna
Details
Sides of bookmark icon are cut off (1.77 KB, image/png)
2019-01-18 20:39 UTC, Noah Davis
Details
Breeze Dark bookmark icon with Kate's Normal Color Scheme (1.17 KB, image/png)
2019-01-18 20:41 UTC, Noah Davis
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriele Menna 2019-01-17 07:30:00 UTC
Created attachment 117500 [details]
a screenshot of a pretty invisible bookmark icon over dark background

Bookmark icon, which appears when clicking on the icon border of a text editor instance, is almost invisible, when using a dark background.
Comment 1 Noah Davis 2019-01-18 20:39:18 UTC
Created attachment 117550 [details]
Sides of bookmark icon are cut off
Comment 2 Noah Davis 2019-01-18 20:41:14 UTC
Created attachment 117551 [details]
Breeze Dark bookmark icon with Kate's Normal Color Scheme
Comment 3 Noah Davis 2019-01-18 20:43:22 UTC
It seems there are 2 issues here.

1. The icon is displayed incorrectly (Attachment 2 [details])
2. The icon follows the system color scheme, not the text editor color scheme.
Comment 4 Ahmad Samir 2019-03-02 17:11:32 UTC
The color part, might be a similar issue to bug 403496; could you try the stuff in bug 403496 comment3?
Comment 5 Gabriele Menna 2019-03-13 08:57:48 UTC
I suppose I got where the problem is.

I'm using a ligth color schema for application and icons (Breeze), but a dark dark one for text editor (Breeze Dark).

And breeze bookmark icon becomes pretty invisible over a dark background...
Comment 6 Lothar 2019-04-30 21:12:45 UTC
> 1. The icon is displayed incorrectly
Did not look at your attachement, but guess I know the issue. Tried two times to fix that, looks here good now

https://cgit.kde.org/ktexteditor.git/commit/?id=08d1537b756513face11338a365d7617aea38e5c

With you comment #5 you may consider to close this
Comment 7 Nate Graham 2019-05-01 02:27:15 UTC
Yep, looks like that fixed it. Thanks!