Bug 403252 - Different licenses in code repo and about dialog
Summary: Different licenses in code repo and about dialog
Status: CONFIRMED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-15 22:50 UTC by Anselmo L. S. Melo (anselmolsm)
Modified: 2022-01-21 05:16 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anselmo L. S. Melo (anselmolsm) 2019-01-15 22:50:53 UTC
In the code repo, there's a COPYING file with GPLv3: https://github.com/KDE/discover/blob/master/COPYING

However the application shows it's GPLv2 for those checking the about dialog (Settings->About Discover), which shows what is defined at https://github.com/KDE/discover/blob/master/discover/main.cpp#L102.
Comment 1 Nicolás Alvarez 2020-02-21 20:45:03 UTC
- 'discover' and 'exporter' directories are LGPL v2 or later
- 'libdiscover' and notifier' directories are GPL v2 or later
- COPYING has GPLv3 text
- COPYING.LIB has LGPLv2.1 text
- About box shows GPLv2

This is messier than it looked. Thanks for the report, we'll investigate...
Comment 2 Harald Sitter 2020-02-22 14:46:51 UTC
for just about every application the actual source licenses are not nearly reflected by the about dialog.
what needs to happen to solve this properly is 1) have kaboutdata moved to a stringy spdx license definition 2) have kaboutdialog support spdx expressions and display them smartly 3) implement reuse compliance across the board 4) have an ecm module that can gather up all licenses of source files contributing to a target.
3 and 4 are probably just bonus.