Created attachment 117452 [details] preview view SUMMARY Thumbnails in icon and preview views are not HiDPI, while the rest of the UI including the preview images are correct. STEPS TO REPRODUCE 1. Download and install digikam 5.9.0 on macOS 10.14 2. Switch to icon or preview view 3. Adjust the thumbnails sizes such that they are smallest possible (to exclude the chance that graininess is due to 256x256 thumbnails showing up too huge) OBSERVED RESULT Thumbnails are not HiDPI EXPECTED RESULT Thumbnails are HiDPI SOFTWARE/OS VERSIONS MacOS: 10.14.2 digikam downloaded from https://www.digikam.org/download/ ADDITIONAL INFORMATION The same turning on "Use large thumbnail size for high screen resolution" and rebuilding all thumbnails and restart digikam.
Created attachment 117453 [details] icon view
Problem still reproducible with 6.0.0 beta3 ? https://files.kde.org/digikam/ Take a care that 6.0.0 will change database schema. Make a backup before to run 6.0.0, else you will not able to re-use 5.8.0 with your database. Gilles Caulier
Gwenview has the same problem (bug 373178). We already have bug 371005 and bug 381128. The problem is not the HiDPI display, but a set scaling factor that enlarges all elements and also Widgets with graphics. Maik
(In reply to caulier.gilles from comment #2) > Problem still reproducible with 6.0.0 beta3 ? > > https://files.kde.org/digikam/ > > Take a care that 6.0.0 will change database schema. Make a backup before to > run 6.0.0, else you will not able to re-use 5.8.0 with your database. > > Gilles Caulier Yes, still reproducible with 6.0.0-beta3.
Alan, Can you reproduce the dysfunction using 6.1.0 pre-release package for MacOSX available here : https://files.kde.org/digikam/ Thanks in advance Gilles Caulier
Yes it is still reproducible with 6.1.0-git Build date: Mar 8 2019 (target: debugfull) Rev.: 84fe965baf4976391484b1a5b9aa97c21e1e1a4c
Refer to gwenview bug of 373178 which has fix now. https://bugs.kde.org/show_bug.cgi?id=373178
(In reply to Alan Tam from comment #6) > Yes it is still reproducible with 6.1.0-git > Build date: Mar 8 2019 (target: debugfull) > Rev.: 84fe965baf4976391484b1a5b9aa97c21e1e1a4c I didn't get any information about whether this is going to be fixed or not. As the HiDPI display are more affordable and this bug really affects the user's experience. KDE is a perfect desktop environment for me, but only this image viewer and management application(digikam) makes me to seek alternatives. Recently gwenview fixed the issue and I started to use it, but still lack of the DAM tools like digikam. Really hope the developers can take care of this in next release.
This bug happens on 6.1.0 on OpenSuse on a 4K monitor with KDE as well. The Light Table and Image Editor are affected as well.
Git commit cb6b0ef7519471b78e7cd04807af24b2f893e982 by Maik Qualmann. Committed on 03/05/2019 at 16:53. Pushed by mqualmann into branch 'master'. fix HiDPI problem under Linux # 1 - Preview - Light Table - Image Editor - Slideshow - Thumbnails not yet Related: bug 371005, bug 381128 M +4 -2 core/libs/widgets/graphicsview/graphicsdimgitem.cpp M +2 -1 core/utilities/imageeditor/widgets/imagepreviewitem.cpp M +2 -1 core/utilities/slideshow/slideimage.cpp https://invent.kde.org/kde/digikam/commit/cb6b0ef7519471b78e7cd04807af24b2f893e982
Git commit 4c8c1f998d03064fc5e92a9d0214394965f52cb5 by Maik Qualmann. Committed on 05/05/2019 at 07:57. Pushed by mqualmann into branch 'master'. fix zoom image on HiDPI display Related: bug 371005, bug 381128 FIXED-IN: 6.2.0 M +2 -1 NEWS M +4 -0 core/dplugins/generic/view/glviewer/glviewertexture.cpp M +2 -2 core/libs/widgets/graphicsview/graphicsdimgitem.cpp M +18 -14 core/libs/widgets/graphicsview/imagezoomsettings.cpp M +2 -1 core/libs/widgets/graphicsview/imagezoomsettings.h M +2 -2 core/utilities/imageeditor/widgets/imagepreviewitem.cpp https://invent.kde.org/kde/digikam/commit/4c8c1f998d03064fc5e92a9d0214394965f52cb5
I am now on this problem. To get sharp thumbnails, we need to provide double the size of thumbnail data on a 4K (device pixel ratio == 2) screen. This means that in HiDPI mode, the thumbnails in the database generally have a size of 512 pixels. If we activate the large thumbnails in digiKam we theoretically even need 1024 pixel thumbnails in the database. Maik
Maik, How Gwenview deal with this problem, as it use (if i remember) Opendesktop thumbnail PNG storage in home directory, which is limited to 256x256. Storing PGF image of 1024*1024 in thumb database is not really a problem. Wavelets compression will optimize data size, even if it will be larger than 512*512. GIlles
Git commit 03598614f72122462174804869328afc3b610b8e by Maik Qualmann. Committed on 05/05/2019 at 17:26. Pushed by mqualmann into branch 'master'. add HiDPI support for icon view und thumb bar - trash view not yet - table view not yet M +7 -2 core/libs/database/models/itemthumbnailmodel.cpp M +24 -4 core/libs/threadimageio/thumb/thumbnailcreator.cpp M +7 -3 core/libs/threadimageio/thumb/thumbnailloadthread.cpp M +26 -34 core/libs/widgets/itemview/itemviewdelegate.cpp M +17 -10 core/showfoto/thumbbar/itemviewshowfotodelegate.cpp M +20 -6 core/showfoto/thumbbar/showfotothumbnailmodel.cpp https://invent.kde.org/kde/digikam/commit/03598614f72122462174804869328afc3b610b8e
Note: Reload the view with F5 or rebuild the thumbnails with the Maintenance Tool must be performed. Maik
Git commit 4b90347eeb60e7f2bba6cae0e9e2c8b83b68669b by Maik Qualmann. Committed on 05/05/2019 at 18:46. Pushed by mqualmann into branch 'master'. add HiDPI support for the trash view M +3 -2 core/app/views/stack/trashview.cpp M +1 -0 core/libs/dtrash/CMakeLists.txt M +9 -1 core/libs/dtrash/dtrashitemmodel.cpp https://invent.kde.org/kde/digikam/commit/4b90347eeb60e7f2bba6cae0e9e2c8b83b68669b
Git commit 427e3140290d6776790604101de95fdfa902d56a by Maik Qualmann. Committed on 05/05/2019 at 21:22. Pushed by mqualmann into branch 'master'. add HiDPI thumbnail support for the table view FIXED-IN: 6.2.0 M +2 -1 NEWS M +18 -11 core/app/views/tableview/tableview_column_thumbnail.cpp https://invent.kde.org/kde/digikam/commit/427e3140290d6776790604101de95fdfa902d56a