Bug 403150 - "Show desktop layout indicators" setting is not remembered in the new virtual desktops KCM
Summary: "Show desktop layout indicators" setting is not remembered in the new virtual...
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-12 18:33 UTC by Patrick Silva
Modified: 2019-01-15 21:52 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2019-01-12 18:33:36 UTC
SUMMARY
I'm testing the new virtual desktops support on neon dev unstable.

STEPS TO REPRODUCE
1. search for "virtual desktops" kcm in the apps launcher and open it
2. check "Show desktop layout indicators" option, click "Ok" button
3. reopen the "virtual desktops" kcm
 
OBSERVED RESULT
"Show desktop layout indicators" setting is unchecked.

EXPECTED RESULT
"Show desktop layout indicators" setting checked and applied in the step 2 should be remembed.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Developer Edition
KDE Plasma Version: 5.14.80
KDE Frameworks Version: 5.54.0
Qt Version: 5.11.2
Comment 1 Nate Graham 2019-01-15 16:48:02 UTC
Confirmed. It also doesn't activate itself or the "Apply" cutton the first two times you click it (it works on the third click for me), which is weird.
Comment 2 David Edmundson 2019-01-15 21:52:38 UTC
Git commit 7c15bc7765eb1087c2e6f23854549f6908a2d9b5 by David Edmundson.
Committed on 15/01/2019 at 21:52.
Pushed by davidedmundson into branch 'master'.

[kcmkwin/kwindesktop] Fix error in desktop layout indicator initial state

Summary:
kcm.osdTextOnly is the inverse of "show desktop layout indicators"

The save was inversed, the load was not.

Also port from onCheckedChanged to onToggled as that's emitted only on
user changes and not on binding re-evaluation.

Test Plan:
Toggled it
Reopened KCM
Checked kwinrc

Reviewers: #kwin, ngraham

Reviewed By: ngraham

Subscribers: ngraham, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D18272

M  +3    -3    kcmkwin/kwindesktop/package/contents/ui/main.qml

https://commits.kde.org/kwin/7c15bc7765eb1087c2e6f23854549f6908a2d9b5