Bug 403149 - Krita does not treat changes in layer visibility and names as valid modifications to a document
Summary: Krita does not treat changes in layer visibility and names as valid modificat...
Status: RESOLVED DUPLICATE of bug 389876
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: 4.1.7
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-12 17:59 UTC by Tyson Tan
Modified: 2019-02-18 10:58 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tyson Tan 2019-01-12 17:59:10 UTC
SUMMARY
If all a user do after opening a document was to change some layer names, Krita would not consider the document has been changed and thus cannot save the modified layer names without at least painting something.

STEPS TO REPRODUCE
1. Open a existing multi-layer document
2. Change the names of the layers, do nothing else

OBSERVED RESULT
Since Krita does not consider the document to be modified, there is no * mark in title bar, and thus it cannot save the modified layer names unless you paint something first. I discovered this bug when I was trying to fix a dumb typo in my document's layer names.
Comment 1 Halla Rempt 2019-01-12 18:00:21 UTC
I think we've gone back and forth on this a bunch of times, with some people wanting these changes to make the document modified, and others not...
Comment 2 Tyson Tan 2019-01-12 18:06:45 UTC
My argument would be: 
1) why would anybody change the layer names if they don't want to save them?
2) it has real world usage when someone open a document just to change the layer names before they can present the source file to the next person who will be working on it.
3) The current state is just so confusing. Took me a while to realize why dropbox didn't update my uploaded file -- because Krita did not save the changes in the first place.
Comment 3 Ahab Greybeard 2019-02-18 06:17:53 UTC
I've just encountered this and two other changes that are 'not saveable' when performed in isolation.
These are changing visibility (on/off) of a Transform Mask or a Transparency Mask. There may be other changes that are treated in the same way by krita. In my case I was trying to change all three in one session.
The 'ugly workaround' is to paint a small part in a transparent region then erase what you painted. After that, all changes will be saved.

I'd agree with the arguments of Tyson Tan in Comment 2
Comment 4 Tyson Tan 2019-02-18 08:04:42 UTC
(In reply to Ahab Greybeard from comment #3)
> I've just encountered this and two other changes that are 'not saveable'
> when performed in isolation.
> These are changing visibility (on/off) of a Transform Mask or a Transparency
> Mask. There may be other changes that are treated in the same way by krita.
> In my case I was trying to change all three in one session.
> The 'ugly workaround' is to paint a small part in a transparent region then
> erase what you painted. After that, all changes will be saved.
> 
> I'd agree with the arguments of Tyson Tan in Comment 2

As I have to work with pixel art designs with huge amount and layers and Transform Masks that needed to be switch on and off all the time, this is bugging me so much. ^^;
Comment 5 Halla Rempt 2019-02-18 10:58:01 UTC

*** This bug has been marked as a duplicate of bug 389876 ***