Bug 403141 - Continue no longer the default when deleting items in split
Summary: Continue no longer the default when deleting items in split
Status: RESOLVED UPSTREAM
Alias: None
Product: kmymoney
Classification: Applications
Component: general (show other bugs)
Version: 5.0.2
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2019-01-12 14:04 UTC by Ian Neal
Modified: 2020-03-06 14:24 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Neal 2019-01-12 14:04:33 UTC 
SUMMARY
When deleting items in a split, under 4.8.x, the confirmation dialog used to have "Continue" focused (the default), now it is "Cancel". This means you have to change the focused button before pressing return or click on the button.

STEPS TO REPRODUCE
1. Edit a transaction with more multiple splits
2. Press delete key
3. Look at which button has focus in resultant dialog box

OBSERVED RESULT
Cancel button has focus

EXPECTED RESULT
Continue button has focus

SOFTWARE/OS VERSIONS
Windows: 
MacOS: 
Linux/KDE Plasma: Fedora 28 (xcb windowing system)
(available in About System)
KDE Plasma Version: 5.13.5-1
KDE Frameworks Version: 5.53.0
Qt Version: 5.11.1

ADDITIONAL INFORMATION
Comment 1 Thomas Baumgart 2019-01-12 16:48:45 UTC 
It works for me with using KDE Frameworks 5.45.0. Could it be due to a change in upstream libraries since you use 5.53.0? The documentation at https://api.kde.org/frameworks/kwidgetsaddons/html/namespaceKMessageBox.html#a9a7aa0faa2cf861076586069472d11dc states that the Continue button is the default. The behavior is completely controlled by the KMessageBox object.
Comment 2 Ian Neal 2019-01-12 19:20:49 UTC 
KDE Frameworks 5.53.0 is the latest version that comes with Fedora 28 (and Fedora 29), not sure what other information I can provide.
I can see from the KDE Frameworks code that if KMessageBox::Option is set to Dangerous then the cancel button has focus but not sure what is causing that in this case. It is happening in all ContinueCancel dialogs, not just the one for deleting a split item.
Comment 3 Ian Neal 2019-01-13 00:27:59 UTC 
Also tested using 5.0.2 RPMs from Fedora on Fedora 29 on a different computer with a new blank file. Every dialog that you would expect the continue / yes button to be the default is not, so has the same issue.
Comment 4 Ian Neal 2019-02-03 15:57:03 UTC 
Tested on another computer using the distro's KMyMoney running:
Ubuntu 18.04.1 LTS
Plasma 5.12.7
KDE Frameworks 5.44.0
Qt 5.9.5
xcb windowing system

Issue happens on that platform too, so not just an issue on Fedora.
Comment 5 Ian Neal 2020-03-06 04:54:45 UTC 
Was still happening under Fedora 29, but under Fedora 30 now back is it should be. In Fedora 30 the SOFTWARE/OS VERSIONS are:
KDE Plasma Version: 5.15.5-1
KDE Frameworks Version: 5.64.0
Qt Version: 5.12.5
I'll mark as resolved upstream unless someone has a better suggestion
Comment 6 Jack 2020-03-06 14:24:53 UTC 
If the fix (and original cause) was in Frameworks, as it seems, then I agree, upstream.  If the issue was in the Fedora packaging, it could be downstream.  Hard to tell if nobody else noticed, and not worth further effort.