Bug 403140 - Vector shapes "Pattern fill" not working?
Summary: Vector shapes "Pattern fill" not working?
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: git master (please specify the git hash!)
Platform: Appimage Linux
: NOR normal
Target Milestone: ---
Assignee: Gernene Tan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-12 12:56 UTC by mvowada
Modified: 2019-04-23 01:19 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Video example (442.29 KB, video/mp4)
2019-01-12 12:56 UTC, mvowada
Details

Note You need to log in before you can comment on or make changes to this bug.
Description mvowada 2019-01-12 12:56:42 UTC
Created attachment 117418 [details]
Video example

(Tested using "Krita 4.2.0-pre-alpha (git 0c1da95)" Appimage - "Ubuntu 14.04")

I'm not sure if it's known but "Pattern fill" (vector shapes) is not working here. Steps (see video):

    1. fresh configs
    2. add a "Vector Layer"
    3. add a rectangle shape on it (no fill)
    4. "Select Shapes Tool" > click the rectangle
    5. "Tool Options" > Fill > click the "Pattern fill" button

Actual Results: the rectangle won't get filled with pattern
Expected: fill the selected rectangle with pattern
Comment 1 Ahab Greybeard 2019-01-14 04:27:10 UTC
I confirm that this is the case for appimages 4.1.5, 4.1.7 and the 13-Jan nightly build krita-4.2.0-pre-alpha-097d7e6-x86_64.

You can create a vector shape with a pattern fill but if you select it and change the fill to one that is not pattern filled then it can't be changed back to pattern filled.
Comment 2 Scott Petrovic 2019-01-14 17:28:07 UTC
Patterns aren't even implemented yet for vectors with what I remember. I think we left those in there to "remember" to add them later. We might need to hide those buttons for now if it is going to be a little while before we actually add it
Comment 3 Ahab Greybeard 2019-01-14 19:16:03 UTC
Pattern fill for vector shapes is certainly attempted when creating vector shapes and it works well when created. However, if the image is saved and then later opened, the fill pattern has tiling gaps (as I've just found).

Until it's fully implemented and full working for both creation and editing then it would seem better to hide those options.
Comment 4 Scott Petrovic 2019-04-23 01:19:24 UTC
Git commit 699acd3144919d4c8aa901d5ceb7ea57362af54b by Scott Petrovic, on behalf of Gernene Tan.
Committed on 23/04/2019 at 01:18.
Pushed by scottpetrovic into branch 'master'.

M  +1    -0    libs/ui/widgets/KoFillConfigWidget.cpp
M  +2    -2    libs/ui/widgets/KoFillConfigWidget.ui

https://invent.kde.org/kde/krita/commit/699acd3144919d4c8aa901d5ceb7ea57362af54b