Bug 403121 - Effect previews are inaccurate
Summary: Effect previews are inaccurate
Status: RESOLVED FIXED
Alias: None
Product: kamoso
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-11 23:51 UTC by Nate Graham
Modified: 2019-03-18 13:11 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 19.04.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2019-01-11 23:51:06 UTC
Just what the title says. :)
Comment 1 Aleix Pol 2019-02-06 13:30:34 UTC
This is a design decision. It was a bit weird to look at and spiked CPU consumption.

I'm not convinced.
Comment 2 Nate Graham 2019-02-06 15:07:40 UTC
Allow me to restate this bug report in terms of a problem statement. :)

The Effects UI suffers from the following problems:
1. The thumbnails are not dynamic, so it's impossible to tell what most of them actually do
2. The thumbnails are really small, exacerbating problem #1
3. The thumbnails don't have text labels underneath them, exacerbating problem #1
4. Each thumbnail's static image reflects the first image in your library as a base rather than what the camera is currently seeing, so it often has nothing to do with what the app is currently showing, which is really confusing

Most other camera apps I'm familiar with show a multi-page view, with each page showing a 3x3 grid of dynamic effects with labels that reflect the camera's current view, which solves all four of the above issues.
Comment 3 Nate Graham 2019-02-11 14:17:09 UTC
New title is not really accurate. It's not hard to *choose* an effect, it's hard to *preview* an effect before applying it. This is due to the lack of a text label, the lack of a live preview, and the use of a static image from the gallery as the background rather than what the camera is currently looking at.
Comment 4 Nate Graham 2019-02-16 19:26:42 UTC
Idea: instead of using the first image from the image gallery, silently take a new picture at the moment the gallery is opened and use that as the basis for the effect previews.

The previews still would not be live, but they would at least be less inaccurate. I once had effect thumbnails that depicted me in the Dusseldorf airport while my kids and I were messing around with Kamoso at home. Also this proposal would fix Bug 404456.
Comment 5 Aleix Pol 2019-03-01 17:08:20 UTC
At the moment, as soon as you take a picture the picture it uses is replaced. Isn't that good enough?
Comment 6 Nate Graham 2019-03-01 17:25:44 UTC
No. Consider the following real world situation:
1. I'm experimenting with Kamoso with Clemens in Bielefeld. We take some pictures.
2. I head to the Dusseldorf airport and wait 6 hours for my flight. During that time I start hacking on Kamoso and open the Effects Gallery. The previews show me and Clemens, not me in the Dusseldorf airport.
3. I take some pictures of myself in the Dusseldorf airport in the process of testing things.
4. I fly home and show Kamoso to my kids. Upon opening the Effects Gallery, the previews show me in the Dusseldorf airport.


Making the previews live would be best from a user experience perspective. But if at the moment that's impossible for technical reasons, the next-best thing is to have the preview use a still image that was taken at the moment of opening the Effects Gallery, not the last picture that was taken by the user. The problem with using the last picture in the gallery is that this picture may have been taken in a different location and it's really weird and confusing to see the Dusseldort airport in the effect previews when I'm showing Kamoso to my kids in New Mexico.
Comment 7 Aleix Pol 2019-03-18 12:05:33 UTC
Git commit 9aa6013c80be11839559f7f80500f5e51175861e by Aleix Pol.
Committed on 18/03/2019 at 11:59.
Pushed by apol into branch 'Applications/19.04'.

Use a camera picture for showing the effects for the first time
Related: bug 404456

M  +14   -11   src/kamoso.cpp
M  +1    -1    src/kamoso.h
M  +2    -1    src/qml/Config.qml
M  +6    -3    src/video/webcamcontrol.cpp
M  +2    -1    src/video/webcamcontrol.h

https://commits.kde.org/kamoso/9aa6013c80be11839559f7f80500f5e51175861e