Bug 403100 - KNewFileMenu emits both directoryCreated and fileCreated when a directory has been created
Summary: KNewFileMenu emits both directoryCreated and fileCreated when a directory has...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kio
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Nate Graham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-11 12:39 UTC by Eike Hein
Modified: 2019-01-11 21:23 UTC (History)
5 users (show)

See Also:
Latest Commit: https://commits.kde.org/kio/28dacfe0737515153e0e40dacd7457b7a4840b29
Version Fixed In: 5.54
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Eike Hein 2019-01-11 12:39:19 UTC 
This ends up breaking insert-at-position in Folder View, as a slot is unexpectedly called twice.

It may be that file is held to be a superset of directory, but the API documentation doesn't reflect this, so there's a bug to fix either way.
Comment 1 Nate Graham 2019-01-11 15:45:46 UTC 
Related to/caused by https://phabricator.kde.org/D17911 and https://phabricator.kde.org/D17617
Comment 2 Chinmoy Ranjan Pradhan 2019-01-11 16:37:16 UTC 
Git commit 28dacfe0737515153e0e40dacd7457b7a4840b29 by Chinmoy Ranjan Pradhan.
Committed on 11/01/2019 at 16:37.
Pushed by chinmoyr into branch 'master'.

[KNewFileMenu] Don't emit fileCreated when creating a directory

Summary: BUG: 403100

Test Plan: unit tests pass.

Reviewers: ngraham, hein

Reviewed By: ngraham, hein

Subscribers: kde-frameworks-devel, dfaure

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D18187

M  +15   -15   src/filewidgets/knewfilemenu.cpp

https://commits.kde.org/kio/28dacfe0737515153e0e40dacd7457b7a4840b29
Comment 3 David Faure 2019-01-11 21:14:46 UTC 
Cherry-picked into 5.54.0-rc3