Bug 403073 - Can't remove a removable media when digikam run
Summary: Can't remove a removable media when digikam run
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-Engine (show other bugs)
Version: 5.9.0
Platform: Microsoft Windows Microsoft Windows
: NOR major
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-10 14:25 UTC by Loukournan29
Modified: 2020-07-30 21:28 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 7.1.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Loukournan29 2019-01-10 14:25:42 UTC
SUMMARY
Can't remove a removable media when digikam run

STEPS TO REPRODUCE
1. Plug an USB media
2. Add a folder of this media to the Digikal collection of removable media
3. Browse the photographs from this USB media
4. Request the media unmount at Windows taskbar

OBSERVED RESULT
1. Windows indicate the media is in use.
2. Stop Digikam
3. The media can be unmounted


EXPECTED RESULT
The media must be removed while Digikam is running.


SOFTWARE/OS VERSIONS
Windows: Win7 home/pro french version and up to date
MacOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 caulier.gilles 2019-01-10 14:58:23 UTC
What did you expect ? To remove the media while in use and lost data ?

Seriously. This is a normal behavior...

Gilles Caulier
Comment 2 Loukournan29 2019-01-10 15:28:23 UTC
(In reply to caulier.gilles from comment #1)
> What did you expect ? To remove the media while in use and lost data ?
> 
> Seriously. This is a normal behavior...
> 
> Gilles Caulier

Seriously, why have a specific removable media collection, without specific behaviours ?

I am a software engineer, and I would pleased to join the developpment team to fixed some issues. 
I think that Digikam can reference photographs about a connected removable media (thumbnails, metadata, ...), and then release every ressources to it. The only needs to access then to the media is to display fullscreen the photographs or when editing.

For example, I prefer to preview my shoots before importation. I would like to browse my SD card without the limitations of the importation view. I am used to quick edit (and cancel) some of my photographs to check their values.
Another example, I would like to browse different referenced removable media while Digikam is running.

I noticed your are a main contributor to Digikam. I am interested in documentation translation into french. I contacted the team, but without response up to now.

Paul
Comment 3 Maik Qualmann 2019-01-10 18:56:04 UTC
Presumably, the QFileSystemWatcher prevents the removal of the USB stick. The QFileSystemWatcher is used to detect external changes. I'm already thinking about not monitoring all folders anymore and making it configurable. But that's something for digiKam-6.1.x.

One more note, I understand that they quickly add a USB collection and then remove it, etc. USB collection are designed in digiKam for permanent image collection on a USB drive, which sometimes are not available. But not as a constantly changing USB medium to browse what's available.

Maik
Comment 4 caulier.gilles 2019-01-11 11:31:02 UTC
Paul,

If i remember, to be able to manage media from Windows application require extra right from installation and to patch the Windows configuration database.

This will be the hell to manage and increase the complexity to setup the installer and fight against the antivurus stuff...

Another point, as Maik said, this require Windows API specific code. There is no Qt code as i know to do the job.

So i vote for no...

About the French translators team, did you check well if you contact the right guy. in all cases, the team must be availalble in IRC channel (as i contribute to KDE french translations 15 years ago (:=))).

Best

Gilles Caulier
Comment 5 Maik Qualmann 2019-05-23 19:15:07 UTC
Git commit 8a2cbc6917d48bbc5d0b02b78d7bcda4176688cb by Maik Qualmann.
Committed on 23/05/2019 at 19:10.
Pushed by mqualmann into branch 'master'.

QFileSystemWatcher can now be disabled.
The setting is on the collection page.
The default is off.
Related: bug 407691, bug 406224, bug 398921

M  +21   -13   core/libs/album/engine/albumwatch.cpp
M  +2    -0    core/libs/settings/applicationsettings.cpp
M  +3    -0    core/libs/settings/applicationsettings.h
M  +10   -0    core/libs/settings/applicationsettings_albums.cpp
M  +3    -0    core/libs/settings/applicationsettings_p.cpp
M  +3    -0    core/libs/settings/applicationsettings_p.h
M  +16   -14   core/utilities/setup/collections/setupcollections.cpp

https://invent.kde.org/kde/digikam/commit/8a2cbc6917d48bbc5d0b02b78d7bcda4176688cb
Comment 6 caulier.gilles 2020-07-14 09:41:35 UTC
Hi,

Can you check if this problem still exist with last weekly bundle build of digiKam 7.0.0 available here:

https://files.kde.org/digikam/

Thanks in advance

Gilles Caulier
Comment 7 caulier.gilles 2020-07-30 09:45:13 UTC
digiKam 7.0.0 stable release is now published:

https://www.digikam.org/news/2020-07-19-7.0.0_release_announcement/

We need a fresh feedback on this file using this version.

Thanks in advance

Gilles Caulier
Comment 8 Loukournan29 2020-07-30 21:08:35 UTC
(In reply to caulier.gilles from comment #7)
> digiKam 7.0.0 stable release is now published:
> 
> https://www.digikam.org/news/2020-07-19-7.0.0_release_announcement/
> 
> We need a fresh feedback on this file using this version.
> 
> Thanks in advance
> 
> Gilles Caulier

Hi,

According to my test, the 7.0.0 release fix the issue.

Paul-Antoine Hervin
Comment 9 caulier.gilles 2020-07-30 21:28:50 UTC
Thanks for the feedback

Gilles Caulier