Bug 402957 - Pressing ENTER does not reveal hidden login module in Breeze/Breath Theme for SDDM
Summary: Pressing ENTER does not reveal hidden login module in Breeze/Breath Theme for...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Global Theme packages (other bugs)
Version First Reported In: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-07 02:42 UTC by Tyson Tan
Modified: 2019-01-07 10:42 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tyson Tan 2019-01-07 02:42:40 UTC
SUMMARY
On SDDM login screen using Breeze/Breath theme, the login module would disappear after a while without input. Pressing Enter does not reveal the password input field but actually submit the password. This is a small thing but nonetheless a real nuisance. Combined with SDDM not being able to show masked password letters on some occasions (on multiple screen setup) it is a major source of confusion.

This bug was first reported to SDDM: https://github.com/sddm/sddm/issues/1089 And with David Edmundson pointing it out, we relay it to Plasmashell/Lookandfeel

My opinions:

People usually make their input only when they can see an input field. They probably do not realize they are still inputting password when the password field is absent. Unwanted letters would probably be recorded as part of the password and cause the login to fail, seemingly "without any reason".

People tend to use mouse click or to press a key on their keyboard (usually a modifier/space/enter) to reveal password fields before they consider themselves in a valid password input conversation. This is also how roughly Windows 7+ and many other OS design their login screen.

Although we can move mouse or input letters to reveal the login module, note that clicking a mouse button does not always comes with mouse movement, so it is very confusing as the user would perceive it as "the password field appears only sometimes as I click my mouse".

My suggestions:

1) Allow modifier/enter/space/mouse click/drag to reveal password input module.
2) When the login module is hidden, do not record any password input.
3) When the login module is hidden, do not submit the password by pressing ENTER.
4) Always show correct masked letters when the password input field is on screen.

SOFTWARE/OS VERSIONS
Windows: 
MacOS: 
Linux/KDE Plasma: Manjaro 18.0.2 KDE
(available in About System)
KDE Plasma Version: 5.14.4
KDE Frameworks Version: 5.53.0
Qt Version: 5.12.0
Comment 1 David Edmundson 2019-01-07 10:42:13 UTC
Git commit ce5f209bd7ea7dedbfe137264e73de4e5a632c67 by David Edmundson.
Committed on 07/01/2019 at 10:42.
Pushed by davidedmundson into branch 'master'.

[sddm-theme] Remove blur on login screen when pressing a modifier

Summary:
Clone of b9f9581f99ef3f50c30b26d87a0258e0d2531f4d which was only applied
to the lock screen.

Test Plan: sddm-greeter --test-mode --theme

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D17996

M  +5    -0    sddm-theme/Main.qml

https://commits.kde.org/plasma-workspace/ce5f209bd7ea7dedbfe137264e73de4e5a632c67
Comment 2 David Edmundson 2019-01-07 10:42:13 UTC
Git commit e4212f1800be05ae3d4153d491db38a41cf1cf38 by David Edmundson.
Committed on 07/01/2019 at 10:42.
Pushed by davidedmundson into branch 'master'.

[sddm-theme] Don't handle enter key when blurred

Summary:
Meaning pressing enter just wakes up the display.
Behaviour now matches lock screen.
Test Plan: Ran SDDM

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D17997

M  +11   -3    sddm-theme/Login.qml
M  +2    -0    sddm-theme/Main.qml

https://commits.kde.org/plasma-workspace/e4212f1800be05ae3d4153d491db38a41cf1cf38