Bug 402953 - When in video or burst mode, show an actual stop button somewhere
Summary: When in video or burst mode, show an actual stop button somewhere
Status: RESOLVED FIXED
Alias: None
Product: kamoso
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-07 01:38 UTC by Nate Graham
Modified: 2019-02-15 16:54 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 19.04.0
Sentry Crash Report:


Attachments
Done in Kirogi (69.29 KB, image/png)
2019-02-13 15:39 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2019-01-07 01:38:31 UTC
The buttons for Video and Burst modes are toggles rather than pushbuttons, which is confusing because nothing about their appearance suggests this, and the usability isn't great. Especially in burst mode, escaping from it quickly is rather difficult which is extremely disconcerting.

We should make all of the three mode buttons just be regular old pushbuttons, and conditionally display a "Stop" button when Video or Burst modes are active. That way it will be completely obvious how to stop recording/shooting.
Comment 1 Nate Graham 2019-02-05 20:54:17 UTC
What I think we should do here is the following:
- Make the current action buttons into a three-position toggle that selects the active mode rather than actually doing anything
- Add a dedicated button that shoots/starts recording according to what the current mode is
Comment 2 Aleix Pol 2019-02-07 09:40:01 UTC
That's what we did before 70ea71ddbce67c90f2ad31a4b0fa0f7dcc9e9c7b. It didn't feel right.
Comment 3 Nate Graham 2019-02-07 14:04:32 UTC
(In reply to Aleix Pol from comment #2)
> That's what we did before 70ea71ddbce67c90f2ad31a4b0fa0f7dcc9e9c7b. It
> didn't feel right.
No, what we had before 70ea71ddbce67c90f2ad31a4b0fa0f7dcc9e9c7b is nothing like what I'm proposing (I've tried it).

Previously the actions swapped positions, which did indeed feel wrong and weird. I'm proposing using the correct UX for selecting one state out of many. In other platforms, a segmented control is typically used for this and works fine. On Kirigami, we could have all three actions be toggles, but only allow one to be active at once--and make them all keep their positions. Then a new "Shoot" button is actually used to take the picture/video/burst.
Comment 4 Nate Graham 2019-02-13 15:39:36 UTC
Created attachment 118043 [details]
Done in Kirogi

What Eike has done for Kirogi is a nice mobile implementation of what I've suggesting. See the attached screenshot.

It has a dual-mode selector and a shoot button. Maybe we could even get him to turn this into a re-usable Kirigami component and then we could use it in Kamoso?
Comment 5 Aleix Pol 2019-02-15 16:40:15 UTC
That could work, I'm not sure if that would be a final solution though as it still maybe will collide with 402948. 

For now I'll fix the actual issue you reported here by changing it into a stop button.
Comment 6 Nate Graham 2019-02-15 16:41:34 UTC
That seems reasonable for now. Let's see how it turns out!
Comment 7 Aleix Pol 2019-02-15 16:43:26 UTC
Git commit e75e152703481db6240e50b743448d9dfea49cc0 by Aleix Pol.
Committed on 15/02/2019 at 16:39.
Pushed by apol into branch 'master'.

Set a stop button for checkable actions

M  +2    -2    src/qml/Main.qml

https://commits.kde.org/kamoso/e75e152703481db6240e50b743448d9dfea49cc0