Kamoso from git master When I run Kamoso on the desktop I see the mobile view, with the floating triple-button toolbar on the bottom instead of a toolbar on top, and the left pane collapsed behind a hamburger button instead of it being always visible. This persists even if I make the window huge. Kamoso should only show this view when in mobile mode or when the window is tiny. Desktop users want a desktop UI.
This was a design decision. Button placement doesn't feel alright at the toolbar. Desktop UI doesn't apply, see Cheese or the Apple one, they all have the controls at the bottom of the UI. We can add a File > Take picture menu too, that doesn't mean we should do it.
Created attachment 117876 [details] ElementaryOS camera app with toolbar on top One thing I really like about Kirigami is how it allows the app to switch between mobile UI and desktop UI dynamically. If we don't use that feature and hardcode the mobile UI, we eliminate a major advantage of Kirigami, lose the opportunity to use Kamoso to showcase its abilities, and we irritate people like me and a whole lot of others who *like* desktop-centric user interfaces on the desktop. I suggest reconsidering. FWIW ElementaryOS's camera app has a toolbar on the top and it looks great. See attachment.
It does look good. I guess in this case having the main action button in the center is important. It could make sense to look into doing something ad-hoc for desktop.
I agree, centering the action buttons would definitely be a prerequisite for using a top-toolbar layout on the desktop. Tracking that in Bug 404203.
Git commit 872cfbcbd7cf1ec52df69434b3f93b4a72bd5d45 by Nate Graham. Committed on 16/09/2019 at 14:38. Pushed by ngraham into branch 'master'. Add a mode to center actions and omit the title when using a ToolBar style Summary: This patch implements an optional and off-by-default feature to center the actions and omit the title when displaying the ToolBar style. This is useful for simple desktop apps that don't need to display a title in the toolbar, where centered toolbuttons look better than right-aligned toolbuttons. Related: bug 404203 FIXED-IN: 5.63 Test Plan: Apply this patch to Kirigami then run Kamoso after applying D23847. Before: {F7338499} After: {F7338498} Reviewers: #kirigami, #vdg, mart, ndavis Reviewed By: #kirigami, #vdg, mart, ndavis Subscribers: plasma-devel Tags: #kirigami Differential Revision: https://phabricator.kde.org/D23845 M +1 -0 src/controls/PageRow.qml M +1 -0 src/controls/private/globaltoolbar/PageRowGlobalToolBarStyleGroup.qml M +11 -2 src/controls/private/globaltoolbar/ToolBarPageHeader.qml https://commits.kde.org/kirigami/872cfbcbd7cf1ec52df69434b3f93b4a72bd5d45
Git commit 5a6f8f243204e5cc519ac3be7b9807b780118db0 by Nate Graham. Committed on 16/09/2019 at 15:25. Pushed by ngraham into branch 'master'. When in Desktop view, show a desktop-style toolbar with centered actions Summary: One thing that has bugged me about Kamoso forever is how it insists on looking like a mobile app when run on the desktop. This seems to be to be contrary to Kirigami's reason for existence and does not showcase the toolkit's excellent convergence features. This patch resolves that by using the default auto-switching feature and therefore displays a desktop-style toolbar when run on the desktop. To improve the appearance, it makes use of a new optional feature in Kirigami added in D23845 to center the actions when in desktop toolbar mode. FIXED-IN: 19.12.0 Depends on D23845 Test Plan: Apply D23845 to Kirigami, then apply this to Kamoso and run the app. Before: {F7338519} After: {F7338520} When D23845 is not applied, the actions are right-aligned, but nothing bad happens, so I opted not to increase the required Frameworks version in the CMakeLists.txt file. Reviewers: apol, #vdg, ndavis Reviewed By: #vdg, ndavis Differential Revision: https://phabricator.kde.org/D23847 M +1 -1 src/qml/Main.qml https://invent.kde.org/kde/kamoso/commit/5a6f8f243204e5cc519ac3be7b9807b780118db0