Bug 402809 - Clicking on "Import" toolbar button in import preview does nothing
Summary: Clicking on "Import" toolbar button in import preview does nothing
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Import-Albums (show other bugs)
Version: 6.0.0
Platform: Appimage Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-03 08:55 UTC by Jens
Modified: 2019-01-03 21:07 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 6.0.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jens 2019-01-03 08:55:57 UTC
SUMMARY
see $SUBJECT

STEPS TO REPRODUCE
1. insert USB device with images on it, select Import in Digikam
2. preview appears with thumbnails
3. select some images, or select all, or select none, and press "Import" in the toolbar

OBSERVED RESULT
Nothing happens

EXPECTED RESULT
The import button (which is actually a dropdown menu with three choices) should automatically select the most appropriate action: if some images are selected, clicking on it should "Import selected", if all or none are selected, it should start "Import new". "Import all" should only be used if explicitly all images are displayed, and also selected. 

Or, at least, the button should cause the menu to open, so the users are not confused as to why nothing happens.


Using the most current appimage on KDE-Neon 18.04 with all updates applied.
Comment 1 Jens 2019-01-03 08:56:59 UTC
PS: This bug is old, I also witnessed it on Digikam 4.14 already. It survived multiple Digikam and even system upgrades and new installations so I expect it's not a config issue. 
I just never got around to reporting it. :-/
Comment 2 Maik Qualmann 2019-01-03 21:01:31 UTC
Git commit 8d577da6a46d8fa1113a46f2958ab08fc34b9321 by Maik Qualmann.
Committed on 03/01/2019 at 20:58.
Pushed by mqualmann into branch 'master'.

use download new as default action for the download tool button
FIXED-IN: 6.0.0

M  +2    -1    NEWS
M  +3    -0    core/utilities/import/main/importui.cpp

https://commits.kde.org/digikam/8d577da6a46d8fa1113a46f2958ab08fc34b9321
Comment 3 Maik Qualmann 2019-01-03 21:07:54 UTC
The selection of the action depending on the image selection is bad, because after the start of import always the first image is selected. I think "Download New" is the best choice for the most users.

Maik