Bug 402756 - Highlight annotation should inherit visual style (e.g. rounded vs square) from widget theme
Summary: Highlight annotation should inherit visual style (e.g. rounded vs square) fro...
Status: RESOLVED UPSTREAM
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-01 14:20 UTC by avlas
Modified: 2019-01-15 22:05 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description avlas 2019-01-01 14:20:51 UTC
Similarly to the change done in the look and feel of events in Calendar, I would recommend to eliminate the rounded style of highlighting in Okular, or at least add an style option for users to control how rounded vs. flat it looks.
Comment 1 Luigi Toscano 2019-01-01 14:45:31 UTC
If the request is about the highlighter tool which is part of the annotation tools, the rounding is not really strong as it was in KOrganizer. Did you check how it looks like in Acrobat Reader?
Comment 2 avlas 2019-01-01 14:59:59 UTC
(In reply to Luigi Toscano from comment #1)
> If the request is about the highlighter tool which is part of the annotation
> tools, the rounding is not really strong as it was in KOrganizer. Did you
> check how it looks like in Acrobat Reader?

Yes, I talk about that, and sorry, I meant in comparison to KOrganizer, as you catched :)

Somehow I don't recall a difference between old KOrganizer behavior and current highlight behavior in Okular, but I cannot compare it now as it is gone in KOrganizer, but I believe your words to this regard.

Unfortunately, I cannot compare it to Acroread either, as it is not available in Linux (for quite some years now). Also, I like and care about Okular, not much about Acroread ;)

Anyway, would you consider having an option to modulate how rounded highlighting looks? Would that be hard to implement?

Thanks in advance for considering!
Comment 3 Nate Graham 2019-01-15 16:05:35 UTC
> Anyway, would you consider having an option to modulate how rounded highlighting looks? Would that be hard to implement?
No, this isn't reasonable, sorry. This kind of thing should be determined by the widget style, not specific to Okular.

Can you attach a screenshot of what you're seeing? It doesn't really look that round to me.
Comment 4 avlas 2019-01-15 16:38:53 UTC
(In reply to Nate Graham from comment #3)
> > Anyway, would you consider having an option to modulate how rounded highlighting looks? Would that be hard to implement?
> No, this isn't reasonable, sorry. This kind of thing should be determined by
> the widget style, not specific to Okular.
> 
> Can you attach a screenshot of what you're seeing? It doesn't really look
> that round to me.

Please see the link: https://user-images.githubusercontent.com/3875196/51194918-09dd6a00-18ba-11e9-9aaa-71b4bf232d88.png

I very much prefer sharp highlights, but it's fine if you like rounded highlights. There's not much I can do anyways :)
Comment 5 Nate Graham 2019-01-15 16:41:41 UTC
Yeah, I think this is fine personally. But I do think it would be a sensible change to inherit the selection style from the widget theme. That way themes with square selection highlights (like Breeze) would give you what you want.
Comment 6 avlas 2019-01-15 20:52:11 UTC
(In reply to Nate Graham from comment #5)
> Yeah, I think this is fine personally. But I do think it would be a sensible
> change to inherit the selection style from the widget theme. That way themes
> with square selection highlights (like Breeze) would give you what you want.

That would be great!
Comment 7 Albert Astals Cid 2019-01-15 21:51:51 UTC
(In reply to Nate Graham from comment #5)
> Yeah, I think this is fine personally. But I do think it would be a sensible
> change to inherit the selection style from the widget theme. That way themes
> with square selection highlights (like Breeze) would give you what you want.

Only that this is not a selection, this is an highlight annotation, widget styles don't have the concept of "highlight annotation", so no this has nothing to do with "The visual style".

On top of that what you're seeing is not rendered by Okular but by Poppler, the ones rendered by Okular (i.e. non pdf file highlights) have square corners.

I'd sincerely close this bug as NOT A BUG
Comment 8 avlas 2019-01-15 22:05:21 UTC
> Only that this is not a selection, this is an highlight annotation, widget
> styles don't have the concept of "highlight annotation", so no this has
> nothing to do with "The visual style".
> 
> On top of that what you're seeing is not rendered by Okular but by Poppler,
> the ones rendered by Okular (i.e. non pdf file highlights) have square
> corners.

I see. Good to know. Thanks!

> I'd sincerely close this bug as NOT A BUG

I'd disagree. I think closing as UPSTREAM would be more appropriate then... (I may consider reporting it to Poppler, will see).

I'm doing it myself. Change it if you feel it is not proper.