Bug 402687 - broken link for SPDX License Expressions
Summary: broken link for SPDX License Expressions
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
: 401860 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-12-29 20:54 UTC by Andrey
Modified: 2019-06-09 00:31 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: AppStream 0.12.5


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey 2018-12-29 20:54:00 UTC
App's "License:" info contains broken link if AppData has Composite License Expressions in it's <project_license/> tag.

Example:
<project_license>LicenseRef-proprietary=https://support.gog.com/hc/en-us/articles/212632089-User-Agreement AND BSD-2-Clause</project_license>

The link generated: 404 Not Found:
https://spdx.org/licenses/LicenseRef-proprietary=https://support.gog.com/hc/en-us/articles/212632089-User-Agreement%20AND%20BSD-2-Clause.html#licenseText
Comment 1 Aleix Pol 2019-01-09 14:35:55 UTC
https://github.com/ximion/appstream/pull/213
Comment 2 Aleix Pol 2019-01-11 12:53:32 UTC
No, now it needs implementing in Discover. We just couldn't do it without having the information available.
Comment 3 Nate Graham 2019-01-11 15:49:29 UTC
Oops, sorry about that!
Comment 4 Aleix Pol 2019-01-14 17:55:47 UTC
*** Bug 401860 has been marked as a duplicate of this bug. ***
Comment 5 Aleix Pol 2019-05-14 12:29:33 UTC
Git commit 9eb621e00af8838091857200fbd2578695591f60 by Aleix Pol.
Committed on 14/05/2019 at 02:07.
Pushed by apol into branch 'master'.

Fix license display

When we know it's an SPDX license, parse it and offer the result.
Otherwise provide the provided text raw.

M  +13   -6    discover/qml/ApplicationPage.qml
M  +11   -3    libdiscover/CMakeLists.txt
C  +31   -11   libdiscover/appstream/AppStreamUtils.cpp [from: libdiscover/appstream/AppStreamUtils.h - 065% similarity]
M  +4    -41   libdiscover/appstream/AppStreamUtils.h
M  +2    -2    libdiscover/backends/DummyBackend/DummyResource.cpp
M  +1    -1    libdiscover/backends/DummyBackend/DummyResource.h
M  +3    -2    libdiscover/backends/FlatpakBackend/FlatpakResource.cpp
M  +1    -1    libdiscover/backends/FlatpakBackend/FlatpakResource.h
M  +2    -2    libdiscover/backends/FwupdBackend/FwupdResource.cpp
M  +1    -1    libdiscover/backends/FwupdBackend/FwupdResource.h
M  +2    -2    libdiscover/backends/KNSBackend/KNSResource.cpp
M  +1    -1    libdiscover/backends/KNSBackend/KNSResource.h
M  +2    -3    libdiscover/backends/PackageKitBackend/AppPackageKitResource.cpp
M  +1    -1    libdiscover/backends/PackageKitBackend/AppPackageKitResource.h
M  +0    -5    libdiscover/backends/PackageKitBackend/LocalFilePKResource.cpp
M  +0    -1    libdiscover/backends/PackageKitBackend/LocalFilePKResource.h
M  +7    -2    libdiscover/backends/PackageKitBackend/PackageKitResource.cpp
M  +1    -1    libdiscover/backends/PackageKitBackend/PackageKitResource.h
M  +2    -2    libdiscover/backends/SnapBackend/SnapResource.cpp
M  +1    -1    libdiscover/backends/SnapBackend/SnapResource.h
M  +5    -2    libdiscover/resources/AbstractResource.h

https://commits.kde.org/discover/9eb621e00af8838091857200fbd2578695591f60
Comment 6 Andrey 2019-06-09 00:09:30 UTC
Still can't see the difference in flatpaked Discover. Why is that?
Comment 7 Andrey 2019-06-09 00:31:53 UTC
Hmm, the latest discover flatpak commit I have is from Mar 14.
And it doesn't have updates apparently.

Is auto-build system works?