Bug 402659 - Find Similar context menu action shows no result if used on an image without a fingerprint.
Summary: Find Similar context menu action shows no result if used on an image without ...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Searches-Similarity (other bugs)
Version First Reported In: 5.9.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-28 17:03 UTC by Kevin M.C.
Modified: 2019-01-09 10:25 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In: 6.0.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin M.C. 2018-12-28 17:03:56 UTC
When the "Find Similar..." context menu action is used on a newly added image without a fingerprint the image is shown in the similarity search box with no result and no feedback.

STEPS TO REPRODUCE
1. Add new folder/image to Albums
2. Right click a newly added image and select Find Similar...

OBSERVED RESULT
Similarity search UI shows up but no results are ever shown.
No hint that something/nothing is going on.


EXPECTED RESULT
Similarity search results are displayed or prompt to compute fingerprints on new images.
(Dragging and dropping the same image in the drop area produces the expected result no matter what.)

SOFTWARE/OS VERSIONS
Windows: 10.0.17763 Build 17763
KDE Frameworks 5.42.0
Qt 5.10.0 (built against 5.10.0)

ADDITIONAL INFORMATION
I think the drag & drop action does something more than the context menu action, maybe computes a fingerprint no matter where the image comes from. I couldn't find a log to look into what is going on exactly.
Comment 1 Mario Frank 2019-01-09 10:25:32 UTC
Git commit b7908fc9894be318e2353a7bc1c4fdab28ded4ef by Mario Frank.
Committed on 09/01/2019 at 10:23.
Pushed by mfrank into branch 'master'.

If fuzzy image search is triggered for an image that currently has
no  or only dirty fingerprint, generate the fingerprint first.
FIXED-IN: 6.0.0

M  +2    -1    NEWS
M  +51   -0    core/libs/database/similaritydb/similaritydb.cpp
M  +19   -0    core/libs/database/similaritydb/similaritydb.h
M  +16   -0    core/utilities/searchwindow/searchmodificationhelper.cpp

https://commits.kde.org/digikam/b7908fc9894be318e2353a7bc1c4fdab28ded4ef