Bug 402641 - Split-view retains title of closed pane
Summary: Split-view retains title of closed pane
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: split view (show other bugs)
Version: 18.12.0
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-28 11:35 UTC by chimak111
Modified: 2019-01-05 16:34 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 18.12.1


Attachments
animated gif (endlessly looping) to illustrate the issue (103.49 KB, image/gif)
2018-12-28 11:35 UTC, chimak111
Details

Note You need to log in before you can comment on or make changes to this bug.
Description chimak111 2018-12-28 11:35:45 UTC
Created attachment 117145 [details]
animated gif (endlessly looping) to illustrate the issue

SUMMARY
Dolphin retains the folder name of the folder even after the respective pane is closed. It should display the name of the remaining open folder

STEPS TO REPRODUCE
1. Open Dolphin. Click on "Split"
2. Open a folder in the new (right) pane different than the folder in the left pane.
3. Close the right pane.

OBSERVED RESULT
The name of the folder that was opened in the right pane is retained in Dolphin's title bar.

EXPECTED RESULT
In my opinion, Dolphin should now show the name of the folder currently displayed and not the name of the folder that was opened in the right-hand-side pane because it is now closed.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: KDE neon 5.14
KDE Plasma Version: 5.14.4
KDE Frameworks Version: 5.53.0
Qt Version: 5.11.2

ADDITIONAL INFORMATION
In the attached animated gif,

I open Dolphin and the home folder is displayed. The title bar shows "Home -- Dolphin"
I click on Split and, in the right pane, double-click on the ".gconf" subfolder. The title bar now shows ".gconf -- Dolphin".
I close the right pane by clicking on Close (previously Split). The title bar still shows  ".gconf -- Dolphin" even though only the home folder is displayed.
Comment 1 Chris Rizzitello 2018-12-28 18:32:21 UTC
I've written a patch to fix this: 
https://phabricator.kde.org/D17840
Comment 2 Elvis Angelaccio 2018-12-30 23:22:49 UTC
Git commit f0e66d34655d5e1eecaed2cab7fd07432aecb714 by Elvis Angelaccio.
Committed on 30/12/2018 at 23:21.
Pushed by elvisangelaccio into branch 'Applications/18.12'.

Add failing test case for bug #402641

M  +32   -0    src/tests/dolphinmainwindowtest.cpp

https://commits.kde.org/dolphin/f0e66d34655d5e1eecaed2cab7fd07432aecb714
Comment 3 Elvis Angelaccio 2019-01-05 16:34:40 UTC
Git commit 504db3f702625c63cb304430e60ab21b9411cb96 by Elvis Angelaccio.
Committed on 05/01/2019 at 16:29.
Pushed by elvisangelaccio into branch 'Applications/18.12'.

Fix title update when changing active split view

Summary:
The DolphinTabPage::activeViewUrlChanged signal triggers the title
update in DolphinMainWindow, which sets the new title from the
`m_activeViewContainer` instance.

This means we need to notify the main window that the active view
changed before telling it that the current url changed.
FIXED-IN: 18.12.1

Reviewers: #dolphin, rizzitello, ngraham

Reviewed By: #dolphin, rizzitello, ngraham

Subscribers: rizzitello, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D17881

M  +1    -1    src/dolphintabpage.cpp
M  +0    -1    src/tests/dolphinmainwindowtest.cpp

https://commits.kde.org/dolphin/504db3f702625c63cb304430e60ab21b9411cb96