Bug 402596 - [feature] Always change the text color when the panel's background is hidden
Summary: [feature] Always change the text color when the panel's background is hidden
Status: RESOLVED INTENTIONAL
Alias: None
Product: lattedock
Classification: Plasma
Component: application (show other bugs)
Version: git (master)
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Michail Vourlakos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-27 02:28 UTC by trmdi
Modified: 2018-12-27 13:18 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
when the monochrome mode is off (6.37 KB, image/png)
2018-12-27 02:28 UTC, trmdi
Details
when the monochrome mode is on (6.69 KB, image/png)
2018-12-27 02:29 UTC, trmdi
Details
faulty results from coloring (199.43 KB, image/png)
2018-12-27 10:38 UTC, Michail Vourlakos
Details

Note You need to log in before you can comment on or make changes to this bug.
Description trmdi 2018-12-27 02:28:50 UTC
Created attachment 117128 [details]
when the monochrome mode is off

When the Latte panel's background is hidden, the text color should always automatically change depending on the background behind it, to contrast with the background.

Currently, the text color changes only when users turn on the monochrome mode, that would break the color of applets like "Color picker". See the screenshots.
Comment 1 trmdi 2018-12-27 02:29:26 UTC
Created attachment 117129 [details]
when the monochrome mode is on
Comment 2 Michail Vourlakos 2018-12-27 10:38:12 UTC
Created attachment 117130 [details]
faulty results from coloring
Comment 3 Michail Vourlakos 2018-12-27 10:45:04 UTC
That could create very annoying faulty results such as the screenshot demonstrates. Latte coloring is not automatic, applets should support it first, that means that applets that do not support it will be painted monochromatic even though they shouldnt. This could be very annoying and could create user frunstationg.

This is why,
[1] Latte coloring should be optional (disable by default, enabled by the user)
[2] Latte will need a way to disable coloring at per applet basis, in order for the user to be able to disable it for those applet that is needed, such as applets that are full colored.
Comment 4 trmdi 2018-12-27 11:02:15 UTC
No, I am not talking about the monochrome mode here.

I am talking about when the monochrome mode is off. And users enable the "hide background..." option. You just need to change the text color in that case:
+ dark background -> white text color
+ light background -> black text color

And that is not the monochrome mode.
Comment 5 Michail Vourlakos 2018-12-27 11:06:21 UTC
> You just need to change the text color in that case:
> + dark background -> white text color
> + light background -> black text color

change the text color for what applets? 

[1] all applets?
[2] applets that support Latte painting?
Comment 6 trmdi 2018-12-27 11:14:55 UTC
For all applets. I think that is a needed action when you hide the panel background.
Comment 7 Michail Vourlakos 2018-12-27 11:16:53 UTC
(In reply to trmdi from comment #6)
> For all applets. I think that is a needed action when you hide the panel
> background.

this is not possible because Plasma does not support it... the textColor can not be changed at per-panel basis, it can be changed only globally for the plasma theme and that means for all plasma theme elements.... applets, tooltips, panels, etc. etc.
Comment 8 Michail Vourlakos 2018-12-27 11:19:17 UTC
you can read: https://phabricator.kde.org/T9769 where this discussion took place...

an initial plasma patch that could provide a way for this to be possible: https://phabricator.kde.org/D15839

is probably considered not appropriate or not a valid solution..
Comment 9 trmdi 2018-12-27 13:18:25 UTC
(In reply to Michail Vourlakos from comment #8)
> you can read: https://phabricator.kde.org/T9769 where this discussion took
> place...
> 
> an initial plasma patch that could provide a way for this to be possible:
> https://phabricator.kde.org/D15839
> 
> is probably considered not appropriate or not a valid solution..

Hmm, I didn't know that. Did you try pinging them ? Maybe they've forgot it.