Bug 402530 - Folder previews are shown for folders that have previews turned off
Summary: Folder previews are shown for folders that have previews turned off
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 18.12.0
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2018-12-24 14:27 UTC by Paul
Modified: 2020-10-27 00:53 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Folder previews when disabled. (170.20 KB, image/png)
2018-12-24 14:33 UTC, Paul
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paul 2018-12-24 14:27:10 UTC
SUMMARY


STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
MacOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Paul 2018-12-24 14:33:50 UTC
Created attachment 117089 [details]
Folder previews when disabled.
Comment 2 Paul 2018-12-24 14:37:54 UTC
SUMMARY
Folder previews are shown even when disabled.

STEPS TO REPRODUCE
1. Disable "Folder Previews" and apply setting.
2. Hover over a folder containing images.
3. 

OBSERVED RESULT
Previews are shown, even though disabled. (See attached screen shot)

EXPECTED RESULT
Previews are not shown.

SOFTWARE/OS VERSIONS

Linux/KDE Plasma: openSUSE 20181219

KDE Plasma Version: 5.14.4
KDE Frameworks Version: 5.53.0
Qt Version: 5.12.0

ADDITIONAL INFORMATION
Comment 3 Julian Steinmann 2018-12-24 15:23:57 UTC
This is an intentional behavior, as the preview in the Information panel is not useful without showing a folder preview. You can turn the whole icon including the preview off by right clicking on the information panel and unchecking "Preview". 

If you have a specific use case for showing an icon, but not the folder preview, please reopen this bug and explain your reason. Thanks!
Comment 4 Paul 2018-12-24 16:37:53 UTC
Yes I have a specific use case...

Unchecking "Preview" (For the Information Panel) is not really a viable option.

From *within* a folder I want previews (Images, Text files etc.) to appear in the Information Panel; this being especially useful when the file listing is "Details" view mode. What I don't want, is a preview of the folder contents when a folder is hovered over.

I'm sorry,  but in my opinion, Dolphin's previous behaviour in this respect was far more sensible :)
Comment 5 Rog131 2018-12-24 18:14:22 UTC
(In reply to Paul from comment #4)
> Yes I have a specific use case...
> 
> Unchecking "Preview" (For the Information Panel) is not really a viable
> option.
> 
> From *within* a folder I want previews (Images, Text files etc.) to appear
> in the Information Panel; this being especially useful when the file listing
> is "Details" view mode. What I don't want, is a preview of the folder
> contents when a folder is hovered over.
> 
> I'm sorry,  but in my opinion, Dolphin's previous behaviour in this respect
> was far more sensible :)

A workaround:

The preview/thumnailer will need the the desktop file to describe the thumbnailer: https://api.kde.org/frameworks/kio/html/classThumbCreator.html.
Remove/move the /usr/share/kservices5/directorythumbnail.desktop file. The directory preview will be disabled.

Note !
Upgrades/updates will install the desktop file again.

Another option: Replace the standard 'Folders' option with another: https://forum.kde.org/viewtopic.php?f=224&t=156241
Comment 6 Paul 2018-12-24 20:21:57 UTC
(In reply to Rog131 from comment #5)
> 
> A workaround:
> 
> The preview/thumnailer will need the the desktop file to describe the
> thumbnailer: https://api.kde.org/frameworks/kio/html/classThumbCreator.html.
> Remove/move the /usr/share/kservices5/directorythumbnail.desktop file. The
> directory preview will be disabled.
> 
> Note !
> Upgrades/updates will install the desktop file again.
> 

Thanks :)  Back to normal now...

Better of course would be if the user's settings (Settings -> Configure Dolphin -> General -> Previews) were honoured.
Comment 7 Nate Graham 2018-12-27 00:44:24 UTC
(In reply to Paul from comment #4)
> What I don't want, is a preview of the folder contents when a folder is hovered over.
Can you explain why?
Comment 8 Paul 2018-12-27 12:25:04 UTC
(In reply to Nate Graham from comment #7)
>
> Can you explain why?
>
Too easy to inadvertently display a preview one would rather keep private... and no, I don't mean p0rn.

What's wrong with obeying the user's settings (Settings -> Configure Dolphin -> General -> Previews) as Dolphin has previously done.

Those who want folder previews can have them, those who don't are able to disable them.  Or is this another case of "Developer Enforcement"? A "feature" becoming more and more common unfortunately ;)
Comment 9 Nate Graham 2018-12-28 00:06:10 UTC
The reasoning behind this was that if you have the information panel open, it's because you want information and previews about selected/hovered items; you wouldn't have the information panel open if you weren't interested in what it displays.

What I think makes  sense is for the Information panel as well as the view to stop drawing folder previews for the contents of folders for which you've turned off previews.

That is to say:
1. Ensure that per-folder view settings are enabled (which is the default)
2. Ensure that folder previews are enabled (which is the default)
3. Turn on previews for ~ (which is the default) using the toolbar button or the menu item
4. Enter ~/Pictures (or whatever) and turn off previews using the toolbar button or the menu item
5. Go back to ~ and look at the folder for ~/Pictures in the view and in the information panel

Observe that the folder icon corresponding to ~/pictures inappropriately shows a preview of its contents in the view and the information panel.
Comment 10 Paul 2018-12-28 12:28:33 UTC
(In reply to Nate Graham from comment #9)
> What I think makes  sense is for the Information panel as well as the view
> to stop drawing folder previews for the contents of folders for which you've
> turned off previews.

Sorry, that doesn't make "sense" to me :)

I have folders where the preview is turned off, but *do* want a preview shown in the information panel.

Stop trying to second guess what the user wants, or attempting to make a "logical" decision.

Simply follow the user's settings for "Folder Previews" (Settings -> Configure Dolphin -> General -> Previews) as Dolphin has previously done.  It sure wasn't broken, so please don't try and fix it.

For myself it's rather a moot point now as I've set up a systemd service file to run a script which deletes "/usr/share/kservices5/directorythumbnail.desktop" ... likely it will remain that way.

Anyway, I'll take this opportunity to wish yourself and your fellow contibutors/developers a happy, and hopefully prosperous, New Year.
Comment 11 Nate Graham 2018-12-28 14:49:52 UTC
I still don't understand your use case. You say:

> I have folders where the preview is turned off, but *do* want a preview
> shown in the information panel.
Then later you say:

> For myself it's rather a moot point now as I've set up a systemd service file
> to run a script which deletes "/usr/share/kservices5/directorythumbnail.desktop"
Which is it? Do you want folder previews always off everywhere, or only off for certain folders?
Comment 12 Paul 2018-12-28 15:16:52 UTC
(In reply to Nate Graham from comment #11)
> I still don't understand your use case. You say:
> 

I apologise, I rather hastily read your comment #9.

Yes, I want folder previews always off everywhere.

As it had always previously been in Dolphin if one deselected "Folder Previews" from "Settings -> Configure Dolphin -> General -> Previews"

I run Dolphin with the Information Panel permanently open.

I'm being very thick here, as I still don't see the need/reason for Previews shown in the Information Panel to ignore the user settings. I rather foolishly thought the purpose of those settings was to allow the user to decide the type of files for which previews were shown. As I said, IMHO it wasn't broken and didn't need fixing.

Nonetheless, as said earlier, I have a workaround now which is perfectly adequate for my own needs using a systemd service file to run a script which deletes "/usr/share/kservices5/directorythumbnail.desktop" at system boot.  As I'm running openSUSE TW I re-boot after any updates, so even if the directorythumbnail.desktop file is re-installed it again gets deleted.


So... whatever... I'll waste your time no more... Thanks.
Comment 13 Justin Zobel 2020-10-27 00:53:36 UTC
Resolving this as only a single user has posted about it in this thread and they are satisfied with the workaround provided.