Bug 402487 - Digital Clock settings inappropriately use tri-state checkbox for 12/24 hour time display
Summary: Digital Clock settings inappropriately use tri-state checkbox for 12/24 hour ...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Digital Clock (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2018-12-23 06:56 UTC by Andres Betts
Modified: 2019-02-28 21:36 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.16.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Betts 2018-12-23 06:56:48 UTC
SUMMARY


STEPS TO REPRODUCE
1. Right click clock 
2. Select Configure digital clock
3. Select appearance
4. Select "Use 24 hour clock"

OBSERVED RESULT


EXPECTED RESULT
There should be a hint that tells users what is the reason for using a half step check box and what it means. Right now, there is no perceivable difference between the toggle.

SOFTWARE/OS VERSIONS
Windows: 
MacOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2018-12-26 19:32:51 UTC
BTW, cannot reproduce. I don't have a half-step checkbox; only on and off.
Comment 2 David Edmundson 2018-12-26 23:45:58 UTC
>BTW, cannot reproduce. I don't have a half-step checkbox; only on and off.

It's a default until a user modifies it.
It means "follow system" - which will either be the same as on or off depending on the locale.

Might be worth taking a step back for other solutions.
Comment 3 Andres Betts 2018-12-26 23:47:51 UTC
I would just suggest a disclaimer below the checkbox
Comment 4 Nate Graham 2018-12-26 23:50:08 UTC
Thanks David!

A half-checked checkbox generally means "some things are selected, but not others." Using it for this UI isn't ideal. In this case, a combobox or a radio button would be better UI, with the options being on, off, and use locale/system default.
Comment 5 Andres Betts 2018-12-26 23:52:29 UTC
I can agree with that too
Comment 6 Nate Graham 2018-12-27 00:18:04 UTC
Something like this:

Time display: Use locale default
              24-hour
              12-hour
Comment 7 Nate Graham 2019-02-22 17:46:53 UTC
Here's a patch: https://phabricator.kde.org/D19230
Comment 8 Nate Graham 2019-02-28 21:36:56 UTC
Git commit 74f0f259465543e52ad93aed2d2fb8471c9f9777 by Nate Graham.
Committed on 28/02/2019 at 21:36.
Pushed by ngraham into branch 'master'.

[Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

Summary:
The use of a tri-state checkbox for the three possible states (12hr, 24hr, use locale
default) is not ideal because it violates the convention regarding what tri-state
checkboxes are used for: nested lists where some sub-items can be unselected.

This patch replaces it with a combobox that clearly indicates all three states.

While we're at it, we add a button to open the Formats KCM in case people want to change their region.
FIXED-IN: 5.16.0

Test Plan:
Tested functionality with `en_US` locale. Check out the clock in the bottom-right corner of
the following screenshots:

Default state: "Use Region Defaults": {F6645570}

Force 12 hour time: {F6645573}

Force 24-hour time: {F6645574}

Reviewers: #plasma, Zren, #vdg, davidedmundson, ndavis

Reviewed By: #plasma, #vdg, davidedmundson, ndavis

Subscribers: cfeck, totte, ndavis, abetts, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D19230

M  +27   -7    applets/digital-clock/package/contents/ui/configAppearance.qml

https://commits.kde.org/plasma-workspace/74f0f259465543e52ad93aed2d2fb8471c9f9777