Bug 402185 - >=kdepim-18.12.0: Make speech dependency optional again
Summary: >=kdepim-18.12.0: Make speech dependency optional again
Status: RESOLVED INTENTIONAL
Alias: None
Product: kdepim
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-16 10:39 UTC by holgersson
Modified: 2021-09-17 17:13 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description holgersson 2018-12-16 10:39:43 UTC
Hi,

up to KDE applications 18.03.x qtspeech and other necessary dependencies for text-to-speech were optional. The 18.12 release introduces a hardcoded dependency inside the build system; please make TTS optional again.

On my distribution, Gentoo, kdepim related packages are the only affected ones I found so far. Therefor I assign it to the KDE PIM product and would politely ask you to reassign it if necessary.

Affected packages on Gentoo:
=kde-apps/kdepim-runtime-18.12.0
=kde-apps/kpimtextedit-18.12.0

Affected parts of these according to our package manager, portage:
--- snip ---
!!! existing preserved libs:
>>> package: dev-qt/qtspeech-5.11.3
 *  - /usr/lib64/libQt5TextToSpeech.so.5
 *  - /usr/lib64/libQt5TextToSpeech.so.5.11.3
 *      used by /usr/bin/akonadi_newmailnotifier_agent (kde-apps/kdepim-runtime-18.12.0-r1)
 *      used by /usr/lib64/libKF5PimTextEdit.so.5.10.0 (kde-apps/kpimtextedit-18.12.0-r1)
--- snap ---

Thanks in advance,
Nils
Comment 1 Christophe Marin 2018-12-16 10:51:20 UTC
This is not a bug, the TTS support is now mandatory.
Comment 2 holgersson 2018-12-16 11:22:17 UTC
Thanks for your fast response. Is there short statement somewhere about the reason for it (or at least an announcement about the new TTS enforcement)?

I personally do not need it at all and would not care if I had only some additional libraries installed, but instead I have new processes like espeak and speech-dispatcher running all the time. I would prefer to limit the used system ressources on the one hand and keep the possible attack surface as small as possible on the other by running only software I actually need.
Comment 3 Christophe Marin 2018-12-16 12:43:32 UTC
Laurent could answer better. I see a couple reasons:

- it was optional when the TTS support in Qt wasn't part of the releases. Nowadays, it's considered stable and is part .

- In the pim repositories, we avoid optional dependencies. The code is cleaner if we don't have to disable chunks of code.
Comment 4 Laurent Montel 2018-12-16 13:23:05 UTC
(In reply to Christophe Giboudeaux from comment #3)
> Laurent could answer better. I see a couple reasons:
> 
> - it was optional when the TTS support in Qt wasn't part of the releases.
> Nowadays, it's considered stable and is part .
> 
> - In the pim repositories, we avoid optional dependencies. The code is
> cleaner if we don't have to disable chunks of code.

Hi,
not necessary to give you more info as Christophe resumed correctly why I removed optional dependancy.
I keep it from long time as optional until this module was stable.
And I wanted to clean up my code.

So it's really intentional.

Regards.
Comment 5 holgersson 2018-12-16 14:17:29 UTC
(In reply to Laurent Montel from comment #4)
> (In reply to Christophe Giboudeaux from comment #3)
> > Laurent could answer better. I see a couple reasons:
> > 
> > - it was optional when the TTS support in Qt wasn't part of the releases.
> > Nowadays, it's considered stable and is part .
> > 
> > - In the pim repositories, we avoid optional dependencies. The code is
> > cleaner if we don't have to disable chunks of code.
> 
> Hi,
> not necessary to give you more info as Christophe resumed correctly why I
> removed optional dependancy.
> I keep it from long time as optional until this module was stable.
> And I wanted to clean up my code.
> 
> So it's really intentional.
> 
> Regards.

OK, is there another possible way to implement it optional while keeping your code reasonable clean, maybe as some kind of plugin? Iā€™d be a happy tester for patches.
Comment 6 Christoph Feck 2018-12-16 14:24:29 UTC
libQt5TextToSpeech.so.5 can be used without speech-dispatcher installed, only its client library "libspeechd2". If QtTextToSpeech cannot connect to the dispatcher, it cannot produce voice, of course.