Bug 402166 - [Flatpak package] REGRESSION: SwipeListItems don't show icons on the right-hand side, though their click areas are still interactive
Summary: [Flatpak package] REGRESSION: SwipeListItems don't show icons on the right-ha...
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: Flatpak Backend (other bugs)
Version First Reported In: unspecified
Platform: Flatpak Linux
: NOR major
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-15 19:18 UTC by Andrey
Modified: 2019-01-07 17:19 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
no buttons for open repos (38.71 KB, image/png)
2018-12-20 15:48 UTC, Andrey
Details
I see the buttons (105.29 KB, image/png)
2018-12-27 00:39 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey 2018-12-15 19:18:25 UTC
This commit have been bisected:
https://phabricator.kde.org/R134:d23440ffca967bbda73950771480b8ca1595d13e

Can't list particular Flatpak sources any more.
Comment 1 Aleix Pol 2018-12-19 17:01:04 UTC
Correct, now you have to press the right-most button to filter.
Comment 2 Andrey 2018-12-19 17:15:31 UTC
Neither left nor right-mouse button has not effect on any flatpak repo now.
So what do you mean?
Comment 3 Andrey 2018-12-20 15:48:25 UTC
Created attachment 117028 [details]
no buttons for open repos

Ok, apparently I can open the repos by pressing on the right-most side of it.
But there is no visible buttons to indicate that spot
Comment 4 Andrey 2018-12-20 16:00:10 UTC
The buttons are absent since the above commit only.
Comment 5 Andrey 2018-12-24 12:00:12 UTC
Aleix, have you been able to reproduce the issue on your side?
You could just try latest flatpak from the app repo
Comment 6 Nate Graham 2018-12-27 00:39:25 UTC
Created attachment 117126 [details]
I see the buttons

With current git master, I see the buttons (see attachment). Can you update to current git master for everything (including Kirigami) and see if the buttons are still absent?
Comment 7 Andrey 2018-12-27 10:36:40 UTC
Nate, please try Discover flatpak.
It's in working state now, but has this problem.

https://community.kde.org/Guidelines_and_HOWTOs/Flatpak#Applications
Comment 8 Nate Graham 2018-12-27 20:13:55 UTC
Ah, so this only affects the Flatpak package of Discover.
Comment 9 Andrey 2018-12-27 20:26:56 UTC
(In reply to Nate Graham from comment #8)
> Ah, so this only affects the Flatpak package of Discover.

But still, this is a regression - note bisected commit in the first comment.
It worked before even for Flatpak
Comment 10 Aleix Pol 2019-01-07 16:38:58 UTC
This will be fixed as soon as we get the new kirigami version in the package.
Feel free to add it 5.54.0-rc1.
Comment 11 Andrey 2019-01-07 17:19:32 UTC
(In reply to Aleix Pol from comment #10)
> This will be fixed as soon as we get the new kirigami version in the package.
> Feel free to add it 5.54.0-rc1.

Maybe keep it open until then? The problem is still there