Bug 402076 - Discover build broken with flatpak
Summary: Discover build broken with flatpak
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: unspecified
Platform: Flatpak Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-12 22:29 UTC by Andrey
Modified: 2018-12-13 18:10 UTC (History)
0 users

See Also:
Latest Commit: https://commits.kde.org/flatpak-kde-applications/a5551dcb6bf06a44caf554b169b4cb2b215dbefb
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey 2018-12-12 22:29:48 UTC 
$ git clone git://anongit.kde.org/flatpak-kde-applications.git

$ flatpak-builder --force-clean --ccache build-dir flatpak-kde-applications/org.kde.discover.json

...
[82/132] Building CXX object libdiscover/backends/FlatpakBackend/CMakeFiles/flatpak-backend.dir/FlatpakTransactionThread.cpp.o
/run/build/discover/libdiscover/backends/FlatpakBackend/FlatpakTransactionThread.cpp:29:13: warning: ‘void flatpakInstallationProgressCallback(const gchar*, guint, gboolean, gpointer)’ defined but not used [-Wunused-function]
 static void flatpakInstallationProgressCallback(const gchar *stats, guint progress, gboolean estimating, gpointer userData)
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[100/132] Building CXX object discover/CMakeFiles/plasma-discover.dir/DiscoverObject.cpp.o
FAILED: discover/CMakeFiles/plasma-discover.dir/DiscoverObject.cpp.o 
/run/ccache/bin/c++   -DKCOREADDONS_LIB -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_FROM_BYTEARRAY -DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT -DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_NO_URL_CAST_FROM_STRING -DQT_QML_LIB -DQT_QUICK_LIB -DQT_USE_QSTRINGBUILDER -DQT_WIDGETS_LIB -DQT_XML_LIB -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -Idiscover -I../discover -I../ -Idiscover/.. -Ilibdiscover -I../libdiscover -isystem /usr/include/KF5/KCrash -isystem /usr/include/KF5 -isystem /usr/include/QtCore -isystem /usr/lib/mkspecs/linux-g++ -isystem /usr/include/KF5/KDBusAddons -isystem /usr/include/QtDBus -isystem /usr/include/KF5/KI18n -isystem /usr/include/KF5/KXmlGui -isystem /usr/include/QtXml -isystem /usr/include/QtWidgets -isystem /usr/include/QtGui -isystem /usr/include/KF5/KConfigCore -isystem /usr/include/KF5/KConfigWidgets -isystem /usr/include/KF5/KCodecs -isystem /usr/include/KF5/KWidgetsAddons -isystem /usr/include/KF5/KConfigGui -isystem /usr/include/KF5/KAuth -isystem /usr/include/KF5/KCoreAddons -isystem /usr/include/KF5/KItemModels -isystem /usr/include/KF5/KIOWidgets -isystem /usr/include/KF5/KIOCore -isystem /usr/include/KF5/KService -isystem /usr/include/QtNetwork -isystem /usr/include/QtConcurrent -isystem /usr/include/KF5/KJobWidgets -isystem /usr/include/KF5/KCompletion -isystem /usr/include/KF5/KDeclarative -isystem /usr/include/QtQuick -isystem /usr/include/QtQml -std=c++0x -fno-operator-names -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -Wvla -Wdate-time -fdiagnostics-color=always -pedantic -Wsuggest-override -Wlogical-op -Wzero-as-null-pointer-constant -fvisibility=hidden -fvisibility-inlines-hidden   -fPIC -std=gnu++11 -MD -MT discover/CMakeFiles/plasma-discover.dir/DiscoverObject.cpp.o -MF discover/CMakeFiles/plasma-discover.dir/DiscoverObject.cpp.o.d -o discover/CMakeFiles/plasma-discover.dir/DiscoverObject.cpp.o -c /run/build/discover/discover/DiscoverObject.cpp
In file included from /usr/include/QtQuick/qquickwindow.h:49:0,
                 from /usr/include/QtQuick/qquickview.h:43,
                 from /usr/include/QtQuick/QQuickView:1,
                 from /run/build/discover/discover/DiscoverObject.h:25,
                 from /run/build/discover/discover/DiscoverObject.cpp:20:
/usr/include/QtQml/qqml.h: In instantiation of ‘int qmlRegisterType() [with T = KAboutData]’:
/run/build/discover/discover/DiscoverObject.cpp:115:33:   required from here
/usr/include/QtQml/qqml.h:107:49: error: ‘staticMetaObject’ is not a member of ‘KAboutData’
     QML_GETTYPENAMES
                                                 ^        
In file included from /usr/include/QtQuick/qquickwindow.h:49:0,
                 from /usr/include/QtQuick/qquickview.h:43,
                 from /usr/include/QtQuick/QQuickView:1,
                 from /run/build/discover/discover/DiscoverObject.h:25,
                 from /run/build/discover/discover/DiscoverObject.cpp:20:
/usr/include/QtQml/qqml.h:118:33: error: ‘staticMetaObject’ is not a member of ‘KAboutData’
         nullptr, 0, 0, nullptr, &T::staticMetaObject,
                                 ^~
In file included from /usr/include/QtQuick/qquickwindow.h:49:0,
                 from /usr/include/QtQuick/qquickview.h:43,
                 from /usr/include/QtQuick/QQuickView:1,
                 from /run/build/discover/discover/DiscoverObject.h:25,
                 from /run/build/discover/discover/DiscoverObject.cpp:20:
/usr/include/QtQml/qqml.h: In instantiation of ‘int qmlRegisterType() [with T = KAboutLicense]’:
/run/build/discover/discover/DiscoverObject.cpp:116:36:   required from here
/usr/include/QtQml/qqml.h:107:49: error: ‘staticMetaObject’ is not a member of ‘KAboutLicense’
     QML_GETTYPENAMES
                                                 ^        
In file included from /usr/include/QtQuick/qquickwindow.h:49:0,
                 from /usr/include/QtQuick/qquickview.h:43,
                 from /usr/include/QtQuick/QQuickView:1,
                 from /run/build/discover/discover/DiscoverObject.h:25,
                 from /run/build/discover/discover/DiscoverObject.cpp:20:
/usr/include/QtQml/qqml.h:118:33: error: ‘staticMetaObject’ is not a member of ‘KAboutLicense’
         nullptr, 0, 0, nullptr, &T::staticMetaObject,
                                 ^~
In file included from /usr/include/QtQuick/qquickwindow.h:49:0,
                 from /usr/include/QtQuick/qquickview.h:43,
                 from /usr/include/QtQuick/QQuickView:1,
                 from /run/build/discover/discover/DiscoverObject.h:25,
                 from /run/build/discover/discover/DiscoverObject.cpp:20:
/usr/include/QtQml/qqml.h: In instantiation of ‘int qmlRegisterType() [with T = KAboutPerson]’:
/run/build/discover/discover/DiscoverObject.cpp:117:35:   required from here
/usr/include/QtQml/qqml.h:107:49: error: ‘staticMetaObject’ is not a member of ‘KAboutPerson’
     QML_GETTYPENAMES
                                                 ^        
In file included from /usr/include/QtQuick/qquickwindow.h:49:0,
                 from /usr/include/QtQuick/qquickview.h:43,
                 from /usr/include/QtQuick/QQuickView:1,
                 from /run/build/discover/discover/DiscoverObject.h:25,
                 from /run/build/discover/discover/DiscoverObject.cpp:20:
/usr/include/QtQml/qqml.h:118:33: error: ‘staticMetaObject’ is not a member of ‘KAboutPerson’
         nullptr, 0, 0, nullptr, &T::staticMetaObject,
                                 ^~
In file included from /usr/include/QtGui/qvector3d.h:45:0,
                 from /usr/include/QtGui/qmatrix4x4.h:44,
                 from /usr/include/QtGui/QMatrix4x4:1,
                 from /usr/include/QtQuick/qsgnode.h:44,
                 from /usr/include/QtQuick/qsgrendererinterface.h:43,
                 from /usr/include/QtQuick/qquickwindow.h:44,
                 from /usr/include/QtQuick/qquickview.h:43,
                 from /usr/include/QtQuick/QQuickView:1,
                 from /run/build/discover/discover/DiscoverObject.h:25,
                 from /run/build/discover/discover/DiscoverObject.cpp:20:
/usr/include/QtCore/qmetatype.h: In instantiation of ‘constexpr int qMetaTypeId() [with T = KAboutData]’:
/usr/include/QtCore/qvariant.h:520:35:   required from ‘QVariant qVariantFromValue(const T&) [with T = KAboutData]’
/usr/include/QtCore/qvariant.h:366:31:   required from ‘static QVariant QVariant::fromValue(const T&) [with T = KAboutData]’
/run/build/discover/discover/DiscoverObject.cpp:128:134:   required from here
/usr/include/QtCore/qmetatype.h:1769:5: error: static assertion failed: Type is not registered, please use the Q_DECLARE_METATYPE macro to make it known to Qt's meta-object system
     Q_STATIC_ASSERT_X(QMetaTypeId2<T>::Defined, "Type is not registered, please use the Q_DECLARE_METATYPE macro to make it known to Qt's meta-object system");
     ^~~~~~~~~~~~~
/usr/include/QtCore/qmetatype.h: In instantiation of ‘static constexpr int QMetaTypeId2<T>::qt_metatype_id() [with T = KAboutData]’:
/usr/include/QtCore/qmetatype.h:1770:43:   required from ‘constexpr int qMetaTypeId() [with T = KAboutData]’
/usr/include/QtCore/qvariant.h:520:35:   required from ‘QVariant qVariantFromValue(const T&) [with T = KAboutData]’
/usr/include/QtCore/qvariant.h:366:31:   required from ‘static QVariant QVariant::fromValue(const T&) [with T = KAboutData]’
/run/build/discover/discover/DiscoverObject.cpp:128:134:   required from here
/usr/include/QtCore/qmetatype.h:1634:89: error: ‘qt_metatype_id’ is not a member of ‘QMetaTypeId<KAboutData>’
     static inline Q_DECL_CONSTEXPR int qt_metatype_id() { return QMetaTypeId<T>::qt_metatype_id(); }
                                                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
/usr/include/QtCore/qmetatype.h:1634:93: error: body of constexpr function ‘static constexpr int QMetaTypeId2<T>::qt_metatype_id() [with T = KAboutData]’ not a return-statement
     static inline Q_DECL_CONSTEXPR int qt_metatype_id() { return QMetaTypeId<T>::qt_metatype_id(); }
                                                                                             ^
[101/132] Building CXX object discover/CMakeFiles/plasma-discover.dir/plasma-discover_automoc.dir/qrc_assets_WCU5OEPW7XGB7L.cpp.o
ninja: build stopped: subcommand failed.
Error: module discover: Child process exited with code 1
Comment 1 Aleix Pol 2018-12-13 02:39:34 UTC 
It's fixed now
Comment 2 Andrey 2018-12-13 14:27:46 UTC 
(In reply to Aleix Pol from comment #1)
> It's fixed now

Hmm, seems it doesn't - see the same erro
Comment 3 Andrey 2018-12-13 15:07:33 UTC 
Sorry, I didn't update the Platform/SDK.

But there is still a problem:
cp: cannot stat 'discoverwrapper.sh': No such file or directory
Error: module discover: Child process exited with code 1

The fix:
diff --git a/org.kde.discover.json b/org.kde.discover.json
index c764385..fac63d9 100644
--- a/org.kde.discover.json
+++ b/org.kde.discover.json
@@ -145,7 +145,7 @@
                     "dest-filename": "discoverwrapper.sh"
                 }
             ],
-            "post-install": [ "cp discoverwrapper.sh /app/bin/" ],
+            "post-install": [ "cp ../discoverwrapper.sh /app/bin/" ],
             "modules-not-building": [
                 {
                     "name": "snapd-glib",


(Sorry I don't handy with phabricator yet)
Comment 4 Aleix Pol 2018-12-13 18:09:56 UTC 
Git commit a5551dcb6bf06a44caf554b169b4cb2b215dbefb by Aleix Pol.
Committed on 13/12/2018 at 18:09.
Pushed by apol into branch 'master'.

discover: fix build

M  +15   -8    org.kde.discover.json

https://commits.kde.org/flatpak-kde-applications/a5551dcb6bf06a44caf554b169b4cb2b215dbefb
Comment 5 Aleix Pol 2018-12-13 18:10:42 UTC 
Git commit a5551dcb6bf06a44caf554b169b4cb2b215dbefb by Aleix Pol.
Committed on 13/12/2018 at 18:09.
Pushed by apol into branch 'master'.

discover: fix build

M  +15   -8    org.kde.discover.json

https://commits.kde.org/flatpak-kde-applications/a5551dcb6bf06a44caf554b169b4cb2b215dbefb