Bug 401969 - LYRICS FEATURE FOR ELISA
Summary: LYRICS FEATURE FOR ELISA
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-10 17:34 UTC by Valter Mura
Modified: 2019-04-15 15:28 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Valter Mura 2018-12-10 17:34:59 UTC
SUMMARY

I would like to have songs' lyrics in Elisa, like Amarok for example.

The program is quite good, but lacks of this feature.

Thank you in advance.
Comment 1 Nate Graham 2018-12-11 18:10:16 UTC
There are two-ish parts to this:
1. Ability display lyrics from the file's Lyrics tag
2. Ability to dynamically display lyrics found on the internet for that song when the tag is empty
2a. Ability to embed those lyrics into the file's tag at the user's discretion

For an example of a good implementation of 1 and 2, see the popular Lollypop GTK app. (You have to right-click on the header and select "Show Lyrics", which is not the most discoverable, but the actual feature works great once you find it!).
Comment 2 Nate Graham 2019-01-15 19:19:31 UTC
JuK also already has this feature: https://cgit.kde.org/juk.git/tree/lyricswidget.cpp

It's actually pretty simple stuff. Perhaps Elisa could grab that -- or even better, perhaps the backend could be extracted into a Framework so that both JuK and Elisa could benefit from it and each others' development?
Comment 3 Matthieu Gallien 2019-04-15 05:47:29 UTC
Git commit 67042c8fcd8ec000093f98b981bd32d1f44b99eb by Matthieu Gallien.
Committed on 14/04/2019 at 13:08.
Pushed by mgallien into branch 'master'.

add support for fetching lyrics in TrackMetaDataModel and display it

M  +43   -0    src/models/trackmetadatamodel.cpp
M  +18   -0    src/models/trackmetadatamodel.h
M  +15   -5    src/qml/ContextView.qml
M  +4    -75   src/qml/MediaTrackMetadataView.qml
M  +30   -3    src/qml/MetaDataDelegate.qml

https://commits.kde.org/elisa/67042c8fcd8ec000093f98b981bd32d1f44b99eb
Comment 4 Nate Graham 2019-04-15 15:28:48 UTC
I love it. :) I'm going to close this and track automatically fetching lyrics from the internet in a new bug: https://bugs.kde.org/show_bug.cgi?id=406568