Bug 401844 - Not all entries in settings page are highlighted on mouseover
Summary: Not all entries in settings page are highlighted on mouseover
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.14.4
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-06 22:42 UTC by Patrick Silva
Modified: 2018-12-25 17:05 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.15.0


Attachments
demonstration (596.45 KB, video/webm)
2018-12-06 22:42 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2018-12-06 22:42:42 UTC
Created attachment 116727 [details]
demonstration

Only the entries related to flatpak backend are highlighted on mouseover, see the screencast please.

EXPECTED RESULT
all entries should be highlighted on mouseover.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.14.4
Qt Version: 5.11.2
KDE Frameworks Version: 5.52.0
Comment 1 Nate Graham 2018-12-08 04:28:02 UTC
Can reproduce with 5.14.4 and git master.
Comment 2 Aleix Pol 2018-12-14 18:15:22 UTC
Git commit 42ed98ba2cc132090a656ef5bcc18444615bf946 by Aleix Pol.
Committed on 14/12/2018 at 18:11.
Pushed by apol into branch 'Plasma/5.14'.

Don't inspect sources if the backend isn't confident about offering good results

Makes it consistent with the hover display

M  +3    -1    discover/qml/SourcesPage.qml

https://commits.kde.org/discover/42ed98ba2cc132090a656ef5bcc18444615bf946
Comment 3 Nate Graham 2018-12-14 18:22:52 UTC
This doesn't actually fix the bug, which requests that all entries should be highlighted on mouseover. Only making entries clickable when the backend exposes useful data retains the inconsistency of the list items having different behavior click and hover behavior from one another.

Either all should be clickable & hoverable or none should--in which case we need a different way to allow you to browse Flatpak apps for a particular source. Maybe putting that functionality into a new hover button?
Comment 4 Aleix Pol 2018-12-15 00:42:08 UTC
Git commit d23440ffca967bbda73950771480b8ca1595d13e by Aleix Pol.
Committed on 14/12/2018 at 19:18.
Pushed by apol into branch 'master'.

Move the filter feature into a delegate action instead of the main action

It's not very common anymore and it felt confusing.

M  +8    -3    discover/qml/SourcesPage.qml

https://commits.kde.org/discover/d23440ffca967bbda73950771480b8ca1595d13e
Comment 5 Nate Graham 2018-12-15 06:23:49 UTC
So much better, and so close! Now all swipelistitems have a hover highlight effect, but (correctly) do nothing when clicked. Can we remove the hover highlight effects?
Comment 6 Aleix Pol 2018-12-15 13:31:06 UTC
Git commit db37fb5d1a82a25aea755c7ca0f7292bc0ae5bc3 by Aleix Pol.
Committed on 15/12/2018 at 13:30.
Pushed by apol into branch 'master'.

sources: Tell the source delegate to not have mouse events

M  +1    -0    discover/qml/SourcesPage.qml

https://commits.kde.org/discover/db37fb5d1a82a25aea755c7ca0f7292bc0ae5bc3
Comment 7 Nate Graham 2018-12-15 16:18:23 UTC
Perfecto!
Comment 8 Patrick Silva 2018-12-25 15:20:01 UTC
why we no longer can browse through the packages available when a repo listed in settings page is clicked?
Comment 9 Nate Graham 2018-12-25 16:31:16 UTC
Because most backends/repos didn't actually support this feature, so it was confusing. For the repos that do (e.g. Flathub), you can click on the little filter icon that appears on the right side of the list item when you hover your mouse over it.
Comment 10 Patrick Silva 2018-12-25 17:05:00 UTC
(In reply to Nate Graham from comment #9)
> For the repos that do (e.g. Flathub), you can click on the little
> filter icon that appears on the right side of the list item when you hover
> your mouse over it.

Thank you Nate.