Bug 401842 - Tooltip of the icons in the favorites list looks ugly after upgrade to Qt 5.12
Summary: Tooltip of the icons in the favorites list looks ugly after upgrade to Qt 5.12
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Menu (Kicker) (show other bugs)
Version: 5.14.4
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL: https://bugreports.qt.io/browse/QTBUG...
Keywords:
: 404083 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-12-06 22:16 UTC by Patrick Silva
Modified: 2019-03-08 09:39 UTC (History)
6 users (show)

See Also:
Latest Commit: https://commits.kde.org/plasma-desktop/ef06af7c01a95339a8f44aafa82e0fd619a9efe9
Version Fixed In: 5.15.3
Sentry Crash Report:

Attachments
tooltip after upgrade to Qt 5.12 (104.59 KB, image/png)
2018-12-06 22:16 UTC, Patrick Silva 		Details
tooltip with Qt 5.11.2 (104.59 KB, image/png)
2018-12-06 22:20 UTC, Patrick Silva 		Details
tooltip with Qt 5.11.2 (126.64 KB, image/png)
2018-12-06 22:29 UTC, Patrick Silva 		Details
Very hard to read menu tooltip (75.28 KB, image/png)
2019-01-28 10:31 UTC, Sete 		Details
Show Obsolete (1) View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2018-12-06 22:16:32 UTC 
Created attachment 116723 [details]
tooltip after upgrade to Qt 5.12

Compare the screenshots please.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.14.4
Qt Version: 5.12.0
KDE Frameworks Version: 5.52.0
Comment 1 Patrick Silva 2018-12-06 22:20:16 UTC 
Created attachment 116725 [details]
tooltip with Qt 5.11.2
Comment 2 Patrick Silva 2018-12-06 22:29:34 UTC 
Created attachment 116726 [details]
tooltip with Qt 5.11.2
Comment 3 Nate Graham 2018-12-08 04:25:34 UTC 
Probably a Qt regression, but it's possible we're doing something weird here to trigger it.
Comment 4 Nate Graham 2018-12-08 04:26:01 UTC 
Is it just these tooltips in Kicker, or any other Plasma tooltips?
Comment 5 Christoph Feck 2018-12-08 15:49:23 UTC 
Only in Kicker. The systray expander tooltip "Show hidden icons", or the more complex ones (e.g. the clock tooltip), have correct margins.

Interestingly, the Calendar popup has differently colored tooltips (Next/Previous Month arrows). These follow tooltip colors set in Systemsettings, while Kicker tooltips do not. I suggest to unify code for tooltips.
Comment 7 Patrick Silva 2018-12-09 16:16:44 UTC 
tooltip is also buggy when I hover over buttons of widgets added to desktop.
And plasma crashes immediately on Wayland when I move the cursor outside the button while the tooltip is still visible.

Operating System: Arch Linux 
KDE Plasma Version: 5.14.4
Qt Version: 5.12.0
KDE Frameworks Version: 5.53.0
Comment 8 Sete 2019-01-28 10:31:51 UTC 
Created attachment 117695 [details]
Very hard to read menu tooltip

Manjaro x64 Plasma KDE 5.14.5
Workspace Theme: Oxygen
Desktop Theme: Air
Icons: Oxygen
Fonts: Ubuntu
Fonts DPI: Default
Resolution: 3840 x 2160
Scale Display: 1.0
Comment 9 Nate Graham 2019-02-01 16:25:04 UTC 
Supposedly/possibly fixed in Qt 5.12.1?

https://bugreports.qt.io/browse/QTBUG-71684
Comment 10 Antonio Rojas 2019-02-02 13:33:58 UTC 
Can confirm it's fixed in Qt 5.12.1
Comment 11 Patrick Silva 2019-02-02 14:52:08 UTC 
Qt 5.12.1 solved the problem on my system too.
Comment 12 Nate Graham 2019-02-08 20:47:52 UTC 
*** Bug 404083 has been marked as a duplicate of this bug. ***
Comment 13 Kai Uwe Broulik 2019-03-08 09:39:22 UTC 
Git commit ef06af7c01a95339a8f44aafa82e0fd619a9efe9 by Kai Uwe Broulik.
Committed on 08/03/2019 at 09:38.
Pushed by broulik into branch 'Plasma/5.15'.

Reset tooltip delegate label height to defaults

It seems Qt 5.12 changed the behavior of contentHeight to not include any font padding.
This is also supposedly fixed in Qt 5.12.1 but this change still makes sense since
assigning contentHeight effectively resets the height anyway so we might as well do it properly.
FIXED-IN: 5.15.3

Differential Revision: https://phabricator.kde.org/D18640

M  +1    -1    applets/kicker/package/contents/ui/main.qml
M  +1    -1    containments/desktop/package/contents/ui/AppletHandle.qml

https://commits.kde.org/plasma-desktop/ef06af7c01a95339a8f44aafa82e0fd619a9efe9