Bug 401734 - Request for adding mmHg as a pressure unit
Summary: Request for adding mmHg as a pressure unit
Status: RESOLVED FIXED
Alias: None
Product: kdeplasma-addons
Classification: Plasma
Component: Weather (show other bugs)
Version: 5.14.1
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2018-12-04 12:32 UTC by Dmitry Nikonov
Modified: 2019-10-27 20:31 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.18.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Nikonov 2018-12-04 12:32:53 UTC
mmHg pressure unit is very common for Russia and some other ex-USSR countries (moreover, almost all Russian weather services use mmHg as the main pressure unit) so it would be nice to have it at the widget.

From my perspective it seems that adding a single line to the `pressureUnitListModelSingletonTypeProvider` definition should completely resolve the issue.
I would offer a patch but since I'm not familiar with the development process I believe it might take some time even for that one line of code.


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.14.1
KDE Frameworks Version: 5.52.0
Qt Version: 5.11.2
Comment 1 Thomas Surrel 2018-12-05 08:52:55 UTC
Hi !
That would be a great opportunity to get your first patch in! You can get some information here: https://community.kde.org/Infrastructure/Phabricator

And of course, don't hesitate to ask if you need any help.
Comment 2 Nate Graham 2018-12-08 04:45:29 UTC
Don't get discouraged, please feel free to submit that patch! We're here to help if you need it.
Comment 3 Dmitry Nikonov 2018-12-11 07:32:58 UTC
Well, that sounds very encouraging.
I think I'll give it a try.

Thank you!
Comment 4 Nate Graham 2018-12-11 14:45:10 UTC
Great, let me know if you need a hand with anything!
Comment 5 Nate Graham 2019-10-27 20:31:20 UTC
Git commit 4092da9d1116bda51a3e9ec8beac310f49bed4a4 by Nate Graham, on behalf of Ismael Asensio.
Committed on 27/10/2019 at 20:31.
Pushed by ngraham into branch 'master'.

Add mmHg to pressure options in weather applet

Summary:
Add millimeters of mercury (mmHg) to pressure options in weather applet, which is a common pressure unit in some countries
FIXED-IN: 5.18.0

Test Plan: You can select 'mmHg' as the pressure unit and it displays correctly in the widget

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24952

M  +2    -1    applets/weather/plugin/plugin.cpp

https://commits.kde.org/kdeplasma-addons/4092da9d1116bda51a3e9ec8beac310f49bed4a4