Bug 401709 - Double clicking a name in a face-frame closes image preview
Summary: Double clicking a name in a face-frame closes image preview
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Faces-Workflow (other bugs)
Version First Reported In: 5.9.0
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-03 18:39 UTC by SkyDiver
Modified: 2018-12-12 17:51 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 6.0.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SkyDiver 2018-12-03 18:39:40 UTC
STEPS TO REPRODUCE
1. From thumbnail images view, double click an image to to to preview mode
2. Add a face frame or edit and existing one
3. Double click the frame's textbox

Reproducible: Always

OBSERVED RESULT
The image preview window closes and switches back to thumbnail view.

EXPECTED RESULT
All the text in the textbox should become selected


SOFTWARE/OS VERSIONS
Linux: Ubuntu
KDE Frameworks Version: 5.42.0
Qt Version: 5.9.3
Comment 1 Maik Qualmann 2018-12-04 07:02:30 UTC
The problem only occurs when in the system the double-click is set to open (Windows, Ubuntu...) As a KF5 Plasma users, I am used to the single click when opening the preview and feel it negative under Windows, for example, always have to double-click to open the preview or to return. In setup we have 2 options either open preview or start image editor.
My proposition: the preview is always opened and closed on every system with a single click. If the image editor is set, the click behavior is used by the system.

Maik
Comment 2 caulier.gilles 2018-12-04 07:04:19 UTC
I agree with Maik proposal from comment #1

Gilles
Comment 3 Maik Qualmann 2018-12-05 21:32:20 UTC
Git commit 7203754025587c95a2e0d956adad13d640526336 by Maik Qualmann.
Committed on 05/12/2018 at 21:30.
Pushed by mqualmann into branch 'master'.

use single mouse click for the preview on all systems
FIXED-IN: 6.0.0

M  +2    -1    NEWS
M  +18   -10   core/app/items/views/digikamitemview.cpp
M  +1    -1    core/app/items/views/digikamitemview.h
M  +3    -3    core/app/items/views/itemcategorizedview.cpp
M  +2    -2    core/app/items/views/itemcategorizedview.h
M  +4    -12   core/libs/widgets/graphicsview/graphicsdimgview.cpp
M  +0    -1    core/libs/widgets/graphicsview/graphicsdimgview.h
M  +17   -29   core/libs/widgets/itemview/itemviewcategorized.cpp
M  +1    -1    core/libs/widgets/itemview/itemviewcategorized.h
M  +3    -3    core/showfoto/thumbbar/showfotocategorizedview.cpp
M  +2    -2    core/showfoto/thumbbar/showfotocategorizedview.h
M  +3    -3    core/utilities/import/views/importcategorizedview.cpp
M  +2    -2    core/utilities/import/views/importcategorizedview.h
M  +1    -1    core/utilities/import/views/importiconview.cpp
M  +1    -1    core/utilities/import/views/importiconview.h

https://commits.kde.org/digikam/7203754025587c95a2e0d956adad13d640526336
Comment 4 Maik Qualmann 2018-12-12 17:51:02 UTC
Git commit b27d57c2f816cd96c0e5caeac2c523f50b740777 by Maik Qualmann.
Committed on 12/12/2018 at 17:49.
Pushed by mqualmann into branch 'master'.

fix double click in the edit field from face name

M  +2    -2    core/libs/widgets/graphicsview/graphicsdimgview.cpp

https://commits.kde.org/digikam/b27d57c2f816cd96c0e5caeac2c523f50b740777