Bug 401610 - plastik decoration blurry
Summary: plastik decoration blurry
Status: RESOLVED WORKSFORME
Alias: None
Product: kwin
Classification: Plasma
Component: decorations (show other bugs)
Version: 5.14.3
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-01 16:15 UTC by cristian_anita
Modified: 2023-02-18 03:47 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
suggested patch (2.50 KB, patch)
2018-12-01 16:15 UTC, cristian_anita
Details
plastik default (8.32 KB, image/png)
2018-12-01 16:15 UTC, cristian_anita
Details
plastik no shadowed text (7.44 KB, image/png)
2018-12-01 16:16 UTC, cristian_anita
Details
plastik patched (7.17 KB, image/png)
2018-12-01 16:16 UTC, cristian_anita
Details

Note You need to log in before you can comment on or make changes to this bug.
Description cristian_anita 2018-12-01 16:15:01 UTC
Created attachment 116603 [details]
suggested patch

I tried to use Plastik windows decoration and noticed that it looks "blurry" (please see attached plastik_default.png). I unchecked "Use shadowed text" and text looks ok but images are still blurry (please see attached plastik_no_shadowed_text).
Looking in code I saw that "Use shadowed text" option does not affect shadowImage.
So I made two small changes:
- default for "Use shadowed text" option is false
- "Use shadowed text" option also affect shadowImage
Result is like in attached plastik_patched.png

I attached patch plastik_no_shadow.diff in case you want to apply it.

Please note that my monitor is FullHD so I do not know how original version looks on 2k or 4k.


SOFTWARE/OS VERSIONS
openSUSE Tumbleweed 20181129
KDE Plasma Version: 5.14.3
KDE Frameworks Version: 5.52.0
Qt Version: 5.11.2
Comment 1 cristian_anita 2018-12-01 16:15:33 UTC
Created attachment 116604 [details]
plastik default
Comment 2 cristian_anita 2018-12-01 16:16:04 UTC
Created attachment 116605 [details]
plastik no shadowed text
Comment 3 cristian_anita 2018-12-01 16:16:32 UTC
Created attachment 116606 [details]
plastik patched
Comment 4 Martin Flöser 2018-12-01 16:57:57 UTC
Please upload the patch on phabricator.kde.org
Comment 5 cristian_anita 2018-12-01 17:35:20 UTC
I tried to upload patch on phabricator but I get:
Diff Parse Exception: Expected a hunk header, like 'Index: /path/to/file.ext' (svn), 'Property changes on: /path/to/file.ext' (svn properties), 'commit 59bcc3ad6775562f845953cf01624225' (git show), 'diff --git' (git diff), '--- filename' (unified diff), or 'diff -r' (hg diff or patch). >>> 1 diff -U 3 -H -d -r -N -- /home/canita/work/kwin4_decoration_qml_plastik_orig/contents/config/main.xml /home/canita/work/kwin4_decoration_qml_plastik/contents/config/main.xml 2 --- /home/canita/work/kwin4_decoration_qml_plastik_orig/contents/config/main.xml 2018-11-06 15:51:43.000000000 +0200 3 +++ /home/canita/work/kwin4_decoration_qml_plastik/contents/config/main.xml 2018-12-01 14:06:26.776420662 +0200 4 @@ -19,7 +19,7 @@ 5 <default>true</default> 6 </entry>

Please note that my patch was made against local install not git sources.
I'll stop here.
Comment 6 Justin Zobel 2023-01-19 00:19:06 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 7 Bug Janitor Service 2023-02-03 05:01:42 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 8 Bug Janitor Service 2023-02-18 03:47:40 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!