Bug 401601 - Elisa should suppress power management when playing
Summary: Elisa should suppress power management when playing
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: 0.3.0
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-01 10:10 UTC by Michael D
Modified: 2019-04-15 15:38 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael D 2018-12-01 10:10:12 UTC
It would be nice if Elisa suppressed power management when playing. Juk and Firefox do this, for example, and it's indicated in the "Battery and Brightness" widget.
Comment 1 Matthieu Gallien 2018-12-01 14:56:57 UTC
Thanks for your report. I will work on it. This is really a nice idea.
Comment 2 Michael D 2018-12-01 20:25:08 UTC
Great, thanks for all your work!
Comment 3 Matthieu Gallien 2019-01-16 20:48:17 UTC
I have created https://phabricator.kde.org/T10360 and started working on it.
Comment 4 Matthieu Gallien 2019-01-18 06:19:04 UTC
The review request https://phabricator.kde.org/D18351 has been created to address that on Plasma and Windows desktops.
It is needed to extend that support to other desktops.
Comment 5 Matthieu Gallien 2019-04-15 05:46:11 UTC
Git commit a44ad7b412674800ad43beb587011515b509d837 by Matthieu Gallien.
Committed on 15/04/2019 at 05:45.
Pushed by mgallien into branch 'master'.

Prevent the host computer to sleep while playing music

Summary:
asks PowerDevil in Plasma to inhibit sleep when playing music

try to get windows to not sleep while playing music in Elisa

Test Plan: tested on a Plasma desktop. Untested on Windows

Tags: #elisa

Maniphest Tasks: T10360

Differential Revision: https://phabricator.kde.org/D18351

M  +1    -0    src/CMakeLists.txt
M  +6    -0    src/audiowrapper_libvlc.cpp
A  +270  -0    src/powermanagementinterface.cpp     [License: LGPL (v3+)]
A  +94   -0    src/powermanagementinterface.h     [License: LGPL (v3+)]

https://commits.kde.org/elisa/a44ad7b412674800ad43beb587011515b509d837
Comment 6 Michael D 2019-04-15 06:47:36 UTC
Great, thanks for your work!
Comment 7 Nate Graham 2019-04-15 15:38:25 UTC
Nice!