Bug 401600 - Incompatible style (colours, fonts) in git/master (v1.1.90-182-gf338282)
Summary: Incompatible style (colours, fonts) in git/master (v1.1.90-182-gf338282)
Status: RESOLVED WORKSFORME
Alias: None
Product: frameworks-purpose
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources All
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-01 09:41 UTC by RJVB
Modified: 2022-12-04 05:15 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screenshot of the incompatibe UI (200.42 KB, image/png)
2018-12-01 09:41 UTC, RJVB
Details
expected UI look (20.92 KB, image/png)
2018-12-01 09:45 UTC, RJVB
Details

Note You need to log in before you can comment on or make changes to this bug.
Description RJVB 2018-12-01 09:41:03 UTC
Created attachment 116599 [details]
screenshot of the incompatibe UI

SUMMARY
A recent commit (49596f29c211fed116d6a4ec7a2ddfd293e2d2d4 or 3888210782af7f49a28744520f1b8773e38df654) introduced a style regression. As a result, the Purpose UI no longer integrates properly with the application that brings it up.

STEPS TO REPRODUCE
1. Install Purpose from git/master
2. Launch KDevelop, trigger a patch review
3. Trigger one of the options under "Export Diff...", for instance the Phabricator option.

OBSERVED RESULT
The UI uses the wrong colours and fonts. See the attached screenshot that includes my font configuration. In this case the background colour isn't respected, and the font used for the dialog title doesn't even look like one from my settings.
Additionally, on Mac the entire dialog is sized to the width of the longest review drop-down entry, which can be considerable.

EXPECTED RESULT
All UI look-and-feel properties should correspond to those in use in the active application.

SOFTWARE/OS VERSIONS
Mac OS X: 10.9.5
Linux: 4.14 
KDE Plasma Version: 5.12.90
KDE Frameworks Version: 5.52.0
Qt Version: 5.9.7
Comment 1 RJVB 2018-12-01 09:45:34 UTC
Created attachment 116600 [details]
expected UI look

This is how I expect the UI to look: matching the UI in use in KDevelop in the other screenshot.
Comment 2 Nate Graham 2022-11-04 17:17:57 UTC
Is this still an issue with the version in Frameworks 5.95 or later?
Comment 3 RJVB 2022-11-04 22:22:26 UTC
I have no idea, I haven't updated my frameworks in ages, and KDevelop's patch review plugin has become pointless so even if the style errors haven't been fixed they're no longer an issue AFAIC.
Comment 4 Bug Janitor Service 2022-11-19 05:14:22 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 5 Bug Janitor Service 2022-12-04 05:15:54 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!