Bug 401423 - Video sidecar files nor read or written
Summary: Video sidecar files nor read or written
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Metadata-Sidecar (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-26 10:53 UTC by Kristian Karl
Modified: 2018-11-27 09:09 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0.0
Sentry Crash Report:


Attachments
A proposed patch that fixes the issue. (1.17 KB, patch)
2018-11-26 10:53 UTC, Kristian Karl
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kristian Karl 2018-11-26 10:53:30 UTC
Created attachment 116506 [details]
A proposed patch that fixes the issue.

SUMMARY
When a settings are set to: 
 "Read from sidecar files" => true
 "Write to sidecar only" => true
Digikam does not read, or write sidecar files for video items.

STEPS TO REPRODUCE
1. Set settings according to above
2. Try to read from or write 
     "Item -> Write Metadata to File"
     "Item -> Reread Metadata From File


OBSERVED RESULT
Metadata in sidecar files are not read, nor is sidecar files written for video files.

EXPECTED RESULT
Metadata should be read and written to sidecar files for video.


SOFTWARE/OS VERSIONS
Windows: 
MacOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 caulier.gilles 2018-11-26 11:10:29 UTC
Which digiKam version did you use exactly ?

Look in Help/Components Info dialog for details.

Gilles Caulier
Comment 2 Maik Qualmann 2018-11-26 11:35:18 UTC
The FilePath is not saved by the FFmpeg Loader is an error, but this can be done later in the code. We do not really want to scan video files with Exiv2. However, it is unavoidable with sidecars. I think we should only do this if the option is enabled in the setup.

Maik
Comment 3 Kristian Karl 2018-11-26 12:24:08 UTC
Oh, sorry for not providing the version information.

I built it from latest master 244785fc86dd446afcb4c2ecc05516ce00f839a7,
using: 
cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DBUILD_TESTING=OFF -DENABLE_MYSQLSUPPORT=ON -DENABLE_INTERNALMYSQL=ON -DENABLE_MEDIAPLAYER=ON -DENABLE_DBUS=ON -DENABLE_APPSTYLES=ON .. && make -j$(nproc --all) && sudo make -j$(nproc --all) install
Comment 4 Maik Qualmann 2018-11-26 19:52:42 UTC
Git commit 47be9d06670ea880d627f2001d9be95f11aa6ae2 by Maik Qualmann.
Committed on 26/11/2018 at 19:51.
Pushed by mqualmann into branch 'master'.

separate loading from sidecar and merge function
FIXED-IN: 6.0.0

M  +2    -1    NEWS
M  +15   -5    core/libs/metadataengine/dmetadata/dmetadata_fileio.cpp
M  +5    -0    core/libs/metadataengine/engine/metaengine.h
M  +20   -0    core/libs/metadataengine/engine/metaengine_fileio.cpp

https://commits.kde.org/digikam/47be9d06670ea880d627f2001d9be95f11aa6ae2
Comment 5 Kristian Karl 2018-11-27 09:09:50 UTC
Tested it, and it looks great.
Thanks!