SUMMARY When a file is changed externally and I do Reload (F5) I get a prompt asking me whether I want to reload the file or ignore the changes, which is unnecessary since my inention is to reload the file STEPS TO REPRODUCE 1. Externally modify an open file 2. Reload OBSERVED RESULT Dialog asking whether I want to reload/ignore changes appears EXPECTED RESULT File reloads immediately SOFTWARE/OS VERSIONS KDE Frameworks Version: 5.52 Qt Version: 5.11.2
Yeah, this makes sense. It should only show you the confirmation message when the reloading happened automatically, not when it was explicitly triggered by the user. I bet the code change to fix this is pretty simple.
Hi there, I'm new to Kate, but I started working on this issue is this ok?
(In reply to Lucas from comment #2) > Hi there, I'm new to Kate, but I started working on this issue is this ok? I've already started working on it. https://phabricator.kde.org/D17178
Oh, ok, thanks!
Git commit 82a1673746eacfe4562b801c5cc45b7c3c0ee233 by Nicolas Fella. Committed on 20/12/2018 at 22:47. Pushed by nicolasfella into branch 'master'. Don't ask for confimation when reloading Summary: When reloading the document it is unnecessary to show the document modified dialog that offers to reload since that is what the user expects. Test Plan: Modify document externally, relaod via F5 -> no confirmation dialog Reviewers: #kate, ngraham, cullmann Reviewed By: #kate, cullmann Subscribers: cullmann, kwrite-devel, kde-frameworks-devel Tags: #kate, #frameworks Differential Revision: https://phabricator.kde.org/D17178 M +0 -23 src/document/katedocument.cpp https://commits.kde.org/ktexteditor/82a1673746eacfe4562b801c5cc45b7c3c0ee233