Bug 401218 - Creating a folder named 'Games' should automatically give it the `folder-games` icon
Summary: Creating a folder named 'Games' should automatically give it the `folder-game...
Status: RESOLVED INTENTIONAL
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-19 18:51 UTC by Matej Mrenica
Modified: 2019-03-19 11:24 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
We could add the settings here (130.40 KB, image/png)
2018-11-23 07:37 UTC, Matej Mrenica
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matej Mrenica 2018-11-19 18:51:55 UTC
SUMMARY


STEPS TO REPRODUCE
1. Create new folder and name it 'Games'
2. 
3. 

OBSERVED RESULT
Normal folder icon is used

EXPECTED RESULT
Games icon should be used

SOFTWARE/OS VERSIONS
Windows: 
MacOS: 
Linux/KDE Plasma: KDE Neon in Docker
(available in About System)
KDE Plasma Version: 5.14.80
KDE Frameworks Version: 5.53
Qt Version: 5.11.2

ADDITIONAL INFORMATION
Not sure about the right 'Product'
Comment 1 Nate Graham 2018-11-19 20:40:26 UTC
We will have a special Games folder icon as of KDE Frameworks 5.53. Are you asking for one in the first place, or asking that creating a folder called "Games" should automatically get this icon?
Comment 2 Matej Mrenica 2018-11-20 05:21:17 UTC
I know you recently added a games icon and I can already choose it manually, but this should be done automatically, and that is what I am asking for.
Comment 3 Matej Mrenica 2018-11-20 05:34:13 UTC
Creating folders with following names: Onedrive, Text, Scripts, Templates, ... ; should also give them special icons, right?
Comment 4 Kai Uwe Broulik 2018-11-20 06:45:14 UTC
We have special icons for all standard paths Qt has (e.g. home, tmp, Pictures, Videos, etc), there's no "the games folder", and I would advise against having a random list of file names that cause magic icons to appear.
Comment 5 Matej Mrenica 2018-11-20 09:26:03 UTC
(In reply to Kai Uwe Broulik from comment #4)
> We have special icons for all standard paths Qt has (e.g. home, tmp,
> Pictures, Videos, etc), there's no "the games folder", and I would advise
> against having a random list of file names that cause magic icons to appear.

So, you are saying, that altough there are icons for various types of folders, we shouldn't use them? Also folders like downloads, videos, music and others have their icons changed, so why not games and others?
Comment 6 Kai Uwe Broulik 2018-11-20 09:48:28 UTC
Sure, you can assign the icons as you please, but there's no XDG_GAMES_DIR standard, so we can't automatically do that.
Comment 7 Matej Mrenica 2018-11-20 10:17:47 UTC
Can you check if there is a folder named 'Games' in home folder (or anywhere) and change its icon?
Comment 8 Kai Uwe Broulik 2018-11-20 10:19:33 UTC
I guess, feel free to toy around with [1].

[1] https://cgit.kde.org/kio.git/tree/src/core/kioglobal_p.cpp
Comment 9 Matej Mrenica 2018-11-20 10:31:31 UTC
(In reply to Kai Uwe Broulik from comment #8)
> I guess, feel free to toy around with [1].
> 
> [1] https://cgit.kde.org/kio.git/tree/src/core/kioglobal_p.cpp

Not sure if I understand the code corectly (as I am not a dev), but can we just add a line like this: 
{ $HOME/Games, QStringLiteral("folder-games") },
? Or maybe "$HOME/Games" ? Or even "~/Games" ?
Comment 10 Christoph Feck 2018-11-22 22:13:54 UTC
Whenever I buy a new disk, I create some folders such as "Archive", "Backup", "Work" etc. on them, and assign various preferred icons. I guess what dolphin/kio could offer is a list/configuration file where a user can add his preferred icons for certain folder names.

I do not like hardcoding associations in source code; names might be language dependent, but I could still have German locale, but create a folder called "Games".
Comment 11 Matej Mrenica 2018-11-23 07:37:19 UTC
Created attachment 116476 [details]
We could add the settings here

We could add the option here, right?
We would also add a new line for games folder path.
Comment 12 Nate Graham 2018-11-26 04:20:20 UTC
I've submitted a patch that adds a generic method of applying default icons to non-XDG dirs by matching both the localized string as well as the English string literal, and populated it with ~/Games by default.

https://phabricator.kde.org/D17167
Comment 13 Matej Mrenica 2019-01-19 08:21:12 UTC
I am sorry, but is this patch included in KDE frameworks 5.54? I am asking, because if yes, then it doesn't seem to work.
Comment 14 Nate Graham 2019-01-19 14:42:35 UTC
The patch has not been accepted, which is why the bug isn't marked as RESOLVED yet.
Comment 15 Nate Graham 2019-03-19 11:24:17 UTC
I'm afraid my patch was rejected for various good reasons. So it doesn't look like we'll be doing this, sorry. :(