Bug 401083 - Duplicated "Source Formatter"
Summary: Duplicated "Source Formatter"
Status: RESOLVED NOT A BUG
Alias: None
Product: kdevelop
Classification: Applications
Component: general (other bugs)
Version First Reported In: 5.3.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: kdevelop-bugs-null
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-15 21:04 UTC by Piotr Mierzwinski
Modified: 2018-12-01 22:41 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Mierzwinski 2018-11-15 21:04:01 UTC
SUMMARY
I'm able to find "Source Formater" in two places. First is configuration of project and second is configuration of KDevelop. I'm confused which one setting should I take into account. 
BTW. In first one I changed settings. I go to configuration of KDevelop and I noticed default settings.

STEPS TO REPRODUCE
1. RMB on project root name and select "Open Configuration".
  At last position in this window is present "Source Formatter".
2. Open Settings -> Configure KDevelop.
  At third position in this window is present "Source Formatter".

OBSERVED RESULT
There are two places where user is able to find "Source Formatter".

EXPECTED RESULT
Should be only one place where we can find "Source Formatter". Otherwise is possible that this will make user be confused.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: YES
(available in About System)
KDE Plasma Version: 5.14.3
KDE Frameworks Version: 5.52
Qt Version: 5.11.2

ADDITIONAL INFORMATION
Comment 1 Friedrich W. H. Kossebau 2018-11-15 22:14:20 UTC
Thanks for reporting your issue.

The two places where source formatting can be configured though are on purpose, so your report shows this is not obvious as it was to the people implementing this :)

Please take another look at the two places: would you have an idea why there once is the option to select a formatting style in the global configuration, and then there is the option to select a formatting style in the per-project configuration, with a switch to use the Default ones (which should be toggled on by default)?

Not yet resolving the motivation by the implementors here, will only do in my following comment. For now curious what the user sees and expects here, so not trying to prime you :)
Comment 2 Piotr Mierzwinski 2018-11-16 00:31:29 UTC
Thank you for explanation.
I think I get it now.

When I toggle on (or will do nothing, because this is default setting) option "Use default" in "Source Formater" placed in project configuration then will be used this global one, otherwise this one set per project.
Am I right?

If yes, then maybe option "Use default" should have different name, like "Use global settings" (in my opinion this name is more clear) or at least have some tool tip explaining its meaning. As you noticed it wasn't clear/obvious for me - at the first look.



BTW. I'm not sure if setting in "Source Formater" works (project configuration), at all. I think like this, because I set here "Language: C++" and "New Qt", pressed Apply, OK. And when I opened again "Source Formater" in project configuration I see default setting, so "Language: C" and "1TBS".
Option "Use default" is not toggled.
Please confirm am I right, or not.
Comment 3 Bug Janitor Service 2018-12-01 03:44:58 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 4 Piotr Mierzwinski 2018-12-01 22:41:22 UTC
No answer for my "BTW...."
Anyway I consider this as no bug only feature.