Bug 400918 - tags are erroneously copied to untagged images in a selection when new tag added
Summary: tags are erroneously copied to untagged images in a selection when new tag added
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Tags-Engine (show other bugs)
Version: 6.0.0
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-10 17:36 UTC by Andrew Goodbody
Modified: 2018-11-10 19:26 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/digikam/a6db63a3bf8eec1c96a801808b170f5c7f775ccf
Version Fixed In: 6.0.0
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Goodbody 2018-11-10 17:36:55 UTC 
SUMMARY
If a selection of images contains images with no tags, and a tag is added to the whole selection then tags from the tagged images will be copied to the untagged images.

STEPS TO REPRODUCE
1. 3 images, one is tagged 'a', the others have no tags, all selected
2. Add tag 'b' so it is added to all images in selection, then 'Apply'
3. 

OBSERVED RESULT
All images are now tagged 'a' and 'b'

EXPECTED RESULT
One image should be tagged 'a' and 'b', other two should be tagged 'b' only.

SOFTWARE/OS VERSIONS
Windows: 
MacOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 5.49.0
Qt Version: 5.11.2

ADDITIONAL INFORMATION
digikam version 6.0.0-beta1
Comment 1 Maik Qualmann 2018-11-10 18:09:34 UTC 
I can not reproduce it. We have already introduced a change here and treated items without tags as partially tagged now. Can you please test it with a more recent version? AppImage from https://files.kde.org/digikam/

Maik
Comment 2 Maik Qualmann 2018-11-10 18:38:45 UTC 
Git commit a6db63a3bf8eec1c96a801808b170f5c7f775ccf by Maik Qualmann.
Committed on 28/09/2018 at 21:59.
Pushed by mqualmann into branch 'master'.

use images without tags also as partially checked
FIXED-IN: 6.0.0

M  +2    -2    NEWS
M  +27   -6    core/libs/imageproperties/disjointmetadata.cpp

https://commits.kde.org/digikam/a6db63a3bf8eec1c96a801808b170f5c7f775ccf
Comment 3 Andrew Goodbody 2018-11-10 19:26:11 UTC 
Yes, that commit fixes the problem.

Sorry for the noise and thank you.