Created attachment 116204 [details] Mips specific code refactor Here are few patches which implement nanoMIPS support. This issue depends on #400593.
Created attachment 116206 [details] Add nanoMIPS support to Valgrind 1/4
Created attachment 116207 [details] Add nanoMIPS support to Valgrind 2/4
Created attachment 116208 [details] Add nanoMIPS support to Valgrind 3/4
Created attachment 116209 [details] Add nanoMIPS support to Valgrind 4/4
Created attachment 116210 [details] Fix some tests so they can be compiled for nanoMIPS
Created attachment 116211 [details] Add tests for nanoMIPS instruction set
Here are few patches which implement nanoMIPS support: * Mips specific code refactor - there is no functional impact but it is necessary in order apply other patches. * nanoMIPS support to Valgrind */4 - Add full support for nanoMIPS architecture, including VEX, Coregrind, makefiles, VKI, ..., README. These patches can be merged into one. * Fix some tests so they can be compiled for nanoMIPS - improve problematic tests so they can be compiled for nanoMIPS. * Add tests for nanoMIPS instruction set - adds nanoMIPS tests. Regression tests are done on x86, AMD64, mips32 and mips64. This issue also depends on #400593. Regards, Aleksandar
I will try to review and merge these changes hopefully soon. If anyone has any objections, please raise them here.
(In reply to Aleksandar Rikalo from comment #1) > Created attachment 116206 [details] > Add nanoMIPS support to Valgrind 1/4 Can you rebase all the changes and make sure no new warnings are generated after the patches are applied?
Created attachment 122259 [details] Add nanoMIPS support to Valgrind 1/4
Created attachment 122260 [details] Add nanoMIPS support to Valgrind 2/4
Created attachment 122261 [details] Add nanoMIPS support to Valgrind 3/4
Created attachment 122262 [details] Add nanoMIPS support to Valgrind 4/4
Created attachment 122263 [details] Fix some tests so they can be compiled for nanoMIPS
Created attachment 122264 [details] Add tests for nanoMIPS instruction set Re-based onto current master branch. There are no regressions on x86 and MIPS platforms.
(In reply to Aleksandar Rikalo from comment #11) > Created attachment 122260 [details] > Add nanoMIPS support to Valgrind 2/4 First of all, thank you for all this work. I have committed majority of the changes from the patches #1 (VEX) and #2 (Coregrind). As I said in a different thread, I believe some parts of it can be omitted or done differently, so please revisit the changes that have not been applied and resend what you believe should still be committed and we can continue discussion from there.
Created attachment 124466 [details] Add nanoMIPS support to Valgrind 3/4
Created attachment 124467 [details] Add nanoMIPS support to Valgrind 4/4
Created attachment 124468 [details] Fix some tests so they can be compiled for nanoMIPS
Created attachment 124469 [details] Add tests for nanoMIPS instruction set
(In reply to Aleksandar Rikalo from comment #17) > Created attachment 124466 [details] > Add nanoMIPS support to Valgrind 3/4 Committed https://sourceware.org/git/gitweb.cgi?p=valgrind.git;a=commit;h=24c1f4ada32ce119dd4b1149c44c5c3d4b7f9b38
(In reply to Aleksandar Rikalo from comment #18) > Created attachment 124467 [details] > Add nanoMIPS support to Valgrind 4/4 Committed https://sourceware.org/git/gitweb.cgi?p=valgrind.git;a=commit;h=deae79f733a7c69f183f0e29a720e6c5bc3c1e7f
(In reply to Aleksandar Rikalo from comment #19) > Created attachment 124468 [details] > Fix some tests so they can be compiled for nanoMIPS Committed https://sourceware.org/git/gitweb.cgi?p=valgrind.git;a=commit;h=192c1673c75737c9ea6b5af7cfdc7b0681759933
(In reply to Aleksandar Rikalo from comment #20) > Created attachment 124469 [details] > Add tests for nanoMIPS instruction set Committed https://sourceware.org/git/gitweb.cgi?p=valgrind.git;a=commit;h=9acc066ffcf37ad04edfc801cc610ae64fa8d771
Thank you for your contribution. There will likely be more changes and finetuning for nanomips, but this set of changes gets majority of support in place.