Bug 400852 - Missing symlinks for help-browser.svg in two subdirectories
Summary: Missing symlinks for help-browser.svg in two subdirectories
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-08 17:19 UTC by jansen
Modified: 2018-11-17 20:36 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.53
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jansen 2018-11-08 17:19:08 UTC
There is a symlink in the directory "apps/48" from "help-browser.svg" to the actual icon "system-help.svg".

The symlink is not present in the directories "apps/16" and "apps/22" where the file "system-help.svg" also exists.

This causes the - much to large in this environment - 48px icon being used in the gvim toolbar. 

Scaling the 48px variant to sizes below 48px is actively prohibited by a "MinSize=48" attribute in the "apps/48" section in "index.theme"!

I suggest adding the symlink to the 16px and 22px directories since I see no reason why the underlying equivalency assumption would not hold for different icon sizes.
Comment 1 Noah Davis 2018-11-17 20:36:09 UTC
Git commit ae50e26abbad988e16d9a146afa7ab5a3ed51886 by Noah Davis, on behalf of Rafael Brandmaier.
Committed on 17/11/2018 at 20:35.
Pushed by ndavis into branch 'master'.

Add help-browser symlink to 16px and 22px directories

Summary:
Add symlink from `help-browser.svg` to `system-help.svg` for `16px` and `22px` sizes.

FIXED-IN: 5.53

Reviewers: #breeze, #vdg, ndavis

Reviewed By: #vdg, ndavis

Subscribers: ndavis, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D16934

A  +1    -0    icons-dark/apps/16/help-browser.svg
A  +1    -0    icons-dark/apps/22/help-browser.svg
A  +1    -0    icons/apps/16/help-browser.svg
A  +1    -0    icons/apps/22/help-browser.svg

https://commits.kde.org/breeze-icons/ae50e26abbad988e16d9a146afa7ab5a3ed51886