Bug 400798 - install might cause a segfault
Summary: install might cause a segfault
Status: RESOLVED WORKSFORME
Alias: None
Product: frameworks-kpackage
Classification: Frameworks and Libraries
Component: default (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-07 13:23 UTC by Maximiliano Curia
Modified: 2020-12-31 04:34 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Package-might-be-gone.patch (1.00 KB, patch)
2018-11-07 13:23 UTC, Maximiliano Curia
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Maximiliano Curia 2018-11-07 13:23:29 UTC
Created attachment 116150 [details]
Package-might-be-gone.patch

SUMMARY

With the introduction of "Emit signals when a package is installed/uninstalled" (b42973d964df159119467030689f36cc005715b5) the autotest PlasmoidPackageTest::noCrashOnAsyncInstall started failing since the test is explicitly making sure the package is destroyed before the install job is executed.

The new connect code in the install procedure uses the package which, in this case is a nullptr. This is supposedly how it's in use by plasmashell (according to the test description).

The attached patch is a workaround that assumes that the package won't become nullptr while handling the connect, thus it's not perfect.

This issue seems to be easily reproducible running the autotests, it would be nice if the autotests are actually tested, at least on release.

Happy hacking,
Comment 1 Nate Graham 2020-12-01 18:19:13 UTC
I'm sorry that your bug report and patch got missed, however this is why we encourage people to submit patches officially. See https://community.kde.org/Infrastructure/GitLab

However, is this still a problem? The autotest is succeeding for me.
Comment 2 Bug Janitor Service 2020-12-16 04:34:03 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 3 Bug Janitor Service 2020-12-31 04:34:25 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!