Created attachment 116119 [details] screenshot showing unrelated action buttons In the ledger view there are buttons for adding and editing transactions as shown in the appended screenshot STEPS TO REPRODUCE 1. start kmymoney 2. open kmymoney file with scheduled transactions or create a new file with at least one scheduled transaction 3. open ledger view 4. select the scheduled transaction OBSERVED RESULT There are no action buttons for the scheduled transaction visible. There are unrelated buttons displayed for regular transactions and it is required to use the context menu to perform a related action. EXPECTED RESULT For scheduled transactions there should be matching action buttons visible in the ledger view. ADDITIONAL INFORMATION Having action buttons for scheduled transaction saves user time on adding/editing.
see https://phabricator.kde.org/D16698 for a related review request.
Created attachment 116120 [details] Screenshot showing buttons for scheduled transactions after applying patch
Git commit 320d67e5cb79974284394d45bfe15f0195be6201 by Ralf Habacker. Committed on 09/11/2018 at 12:41. Pushed by habacker into branch '4.8-staging'. Adding scheduled transactions buttons to the ledger view Summary: The ledger view contains buttons for editing transactions such as New, Edit, Delete, and more. For planned transactions, there are no similar buttons that simplify editing when selected. The order of the buttons between regular and scheduled transactions has been adjusted. FIXED-IN:4.8.3 Test Plan: compiled and checked on linux Reviewers: tbaumgart, wojnilowicz Differential Revision: https://phabricator.kde.org/D16698 M +17 -1 kmymoney/kmymoney.cpp M +8 -1 kmymoney/views/kgloballedgerview.cpp https://commits.kde.org/kmymoney/320d67e5cb79974284394d45bfe15f0195be6201
Git commit 964fc95766b0521cf4ee0d870a419428f2e30664 by Ralf Habacker. Committed on 09/11/2018 at 13:39. Pushed by habacker into branch '4.8-staging'. Adding scheduled transactions buttons to the ledger view Summary: The ledger view contains buttons for editing transactions such as New, Edit, Delete, and more. For planned transactions, there are no similar buttons that simplify editing when selected. The order of the buttons between regular and scheduled transactions has been adjusted. FIXED-IN:4.8.3 Test Plan: compiled and checked on linux Reviewers: tbaumgart, wojnilowicz Differential Revision: https://phabricator.kde.org/D16698 M +17 -1 kmymoney/kmymoney.cpp M +8 -1 kmymoney/views/kgloballedgerview.cpp https://commits.kde.org/kmymoney/964fc95766b0521cf4ee0d870a419428f2e30664
Git commit 84664033008cf8b85cdb0b04bda5cae13741c78e by Ralf Habacker. Committed on 11/11/2018 at 18:28. Pushed by habacker into branch '4.8'. Adding scheduled transactions buttons to the ledger view The ledger view contains buttons for editing transactions such as New, Edit, Delete, and more. For planned transactions, there are no similar buttons that simplify editing when selected. The order of the buttons between regular and scheduled transactions has been adjusted. FIXED-IN:4.8.3 Reviewed By: wojnilowicz Differential Revision: https://phabricator.kde.org/D16698 M +17 -1 kmymoney/kmymoney.cpp M +8 -1 kmymoney/views/kgloballedgerview.cpp https://commits.kde.org/kmymoney/84664033008cf8b85cdb0b04bda5cae13741c78e