Bug 400663 - Digital clock plasmoid has inconsistent callendar settings window layout
Summary: Digital clock plasmoid has inconsistent callendar settings window layout
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Calendar (show other bugs)
Version: 5.14.3
Platform: Neon Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-04 14:05 UTC by soee
Modified: 2018-12-06 18:39 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.15.0


Attachments
Callendar settings window conrent (51.06 KB, image/png)
2018-11-04 14:05 UTC, soee
Details

Note You need to log in before you can comment on or make changes to this bug.
Description soee 2018-11-04 14:05:57 UTC
Created attachment 116082 [details]
Callendar settings window conrent

If we open digital clock plasmoid settings and go to callendar properites section, we will see that whole layout is inconsistent - checkboxes and labels aren't aligned as they should (probably in one vertical line starting from the left).


STEPS TO REPRODUCE
1. Open digital clock settings
2. Got to callendar settings section
3. Watch the layout

OBSERVED RESULT

checkboxes and labels aren't aligned as they should

EXPECTED RESULT

Checkboxes and labels should probably be in one vertical line starting from the left

SOFTWARE VERSIONS
KDE Plasma Version: 5.14.2
KDE Frameworks Version: 5.51
Qt Version: 5.11.2
Comment 1 Nate Graham 2018-11-04 23:14:05 UTC
Will fix.
Comment 2 Nate Graham 2018-12-04 18:15:27 UTC
Sorry that took so long. November was a very busy month for me. Here's the patch: https://phabricator.kde.org/D17354
Comment 3 Nate Graham 2018-12-06 18:39:06 UTC
Git commit ad34212a8ccdb83672fddfc94494b2c800405633 by Nate Graham.
Committed on 06/12/2018 at 18:39.
Pushed by ngraham into branch 'master'.

[Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

Summary:
FIXED-IN: 5.15.0

Test Plan:
Before: {F6455075}

After: {F6459462}

(label alignment being a bit off is unrelated to this patch)

Everything still works.

Reviewers: #plasma, #vdg, mart, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: alexde, mvourlakos, abetts, zzag, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D17354

M  +28   -21   applets/digital-clock/package/contents/ui/configCalendar.qml

https://commits.kde.org/plasma-workspace/ad34212a8ccdb83672fddfc94494b2c800405633