Bug 400542 - Items listed in new Welcome screen's Recent Documents are displayed incorrectly in some occasions
Summary: Items listed in new Welcome screen's Recent Documents are displayed incorrect...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-01 07:29 UTC by Tyson Tan
Modified: 2018-11-02 00:41 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Recent Documents wrong display - type 3 (59.12 KB, image/png)
2018-11-01 07:31 UTC, Tyson Tan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tyson Tan 2018-11-01 07:29:27 UTC
SUMMARY
On Krita's new welcome screen there is a Recent Documents list, pressing Clear there removes all listed items. However, it displays items incorrectly in some occasions.

1) After pressing Clear, the current items stay visible until Krita is restarted.

2) When the list is empty, drag one document into Krita and then close it (do not close Krita), Recent Documents list now displays 2 duplicated items of that document. Restart Krita and the duplicated items are gone.

3) When the list has only one item A, drag another document B into Krita and then close it (do not close Krita), Recent Documents list now displays A and B alternatively until they fill up the list. Restart Krita and the duplicated items are gone.

Tested on Manjaro KDE 18.0, krita-4.2.0-pre-alpha-4b9572f-x86_64.appimage
Comment 1 Tyson Tan 2018-11-01 07:31:09 UTC
Created attachment 116020 [details]
Recent Documents wrong display - type 3
Comment 2 Scott Petrovic 2018-11-01 23:34:01 UTC
Git commit c81830e463f03c978535bdd3c10af4213cd749fc by Scott Petrovic.
Committed on 01/11/2018 at 23:33.
Pushed by scottpetrovic into branch 'master'.

M  +3    -1    libs/ui/KisWelcomePageWidget.cpp
M  +13   -0    libs/ui/forms/KisWelcomePage.ui

https://commits.kde.org/krita/c81830e463f03c978535bdd3c10af4213cd749fc
Comment 3 Scott Petrovic 2018-11-01 23:36:38 UTC
Thanks for the report Tyson.

This is fixed. The recent list on the welcome screen wasn't getting cleared right, so I fixed my bad logic.

I believe this should take care of all 3 of your points.
Comment 4 Tyson Tan 2018-11-02 00:41:48 UTC
Thank you Scott! :D