Bug 400516 - In desktop mode, sheets should not quite touch the sides of the content view
Summary: In desktop mode, sheets should not quite touch the sides of the content view
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: Master
Platform: Other Linux
: NOR wishlist
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-31 14:41 UTC by Nate Graham
Modified: 2018-11-26 16:51 UTC (History)
0 users

See Also:
Latest Commit: https://cgit.kde.org/kirigami.git/commit/?id=337ba709a179dd53187564411fa0109f16d0ceae
Version Fixed/Implemented In: 5.53
Sentry Crash Report:

Attachments
How sheets look on the desktop (66.29 KB, image/jpeg)
2018-10-31 14:41 UTC, Nate Graham 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2018-10-31 14:41:43 UTC 
Created attachment 116004 [details]
How sheets look on the desktop

See attached image, which depicts how Kirigami sheets look right now in desktop mode.

I think the visual style would be improved if the sides of the sheet were not anchored to the sides of the parent view. If there were a bit of padding there instead, then the sheet would seem like it's floating in the parent view, which I think would look better.
Comment 1 Nate Graham 2018-10-31 15:16:02 UTC 
Heck, maybe we should do this on Mobile too (with smaller margins, obviously), just to reinforce the distinctions between pages (full screen) and sheets (not full screen).
Comment 2 Nate Graham 2018-11-26 16:51:04 UTC 
This was fixed in Kirigami recently: https://cgit.kde.org/kirigami.git/commit/?id=337ba709a179dd53187564411fa0109f16d0ceae