Bug 400434 - Trash content disappears after selecting 'Map' or 'Table' view
Summary: Trash content disappears after selecting 'Map' or 'Table' view
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-Trash (show other bugs)
Version: 6.0.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-28 21:31 UTC by Nicofo
Modified: 2018-11-04 15:36 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicofo 2018-10-28 21:31:50 UTC
STEPS TO REPRODUCE
1. Go to Trash (Mode 'Thumbnails' becomes active)  [Trash is not empty]
2a. Select 'Map' mode -> a map appears with no picture
2b. OR Select 'Table' mode -> an empty list appears
3. Select 'Thumbnails' mode again: Trash seems empty !
(It is not: explore another folder and go back to Trash -> content is still present).


NOTE - QUESTION
Why is the 'Preview' mode disabled in the Trash ? For me it should not be disabled ! (I mean I don't see any reason for disabling it)
Eventually other modes ('Table' and 'Maps') could be disabled if too complicated to managed (because these modes require database I suppose ?).
Comment 1 Maik Qualmann 2018-10-28 22:03:34 UTC
Yes, the trash view must work without a database because the items are already marked as deleted in the database. But you're right, in principle, almost all options in the menu must be disabled when the trash view is selected.

Maik
Comment 2 Nicofo 2018-10-29 20:16:43 UTC
OK. And what about 'Preview' mode ? Isn't possible to enable it in the Trash (no need for database I suppose: it is like the 'Thumbnails' mode) ?
Comment 3 Maik Qualmann 2018-10-30 07:54:41 UTC
The preview function in the digiKam main program also requires the database. As I said, the items in the Trash are already marked as deleted and are no longer respected in SQL queries.

Maik
Comment 4 Maik Qualmann 2018-11-04 12:33:35 UTC
Git commit 5e7b75f1263f5a5ff6dbc60cc0782a3fe9b920e4 by Maik Qualmann.
Committed on 04/11/2018 at 12:32.
Pushed by mqualmann into branch 'master'.

first step to disable unneeded action in the trash view

M  +35   -1    core/app/main/digikamapp.cpp
M  +1    -0    core/app/main/digikamapp.h

https://commits.kde.org/digikam/5e7b75f1263f5a5ff6dbc60cc0782a3fe9b920e4
Comment 5 Maik Qualmann 2018-11-04 15:36:43 UTC
Git commit a1c00c61a6558f041a8dc4bcf9e10ee669d55865 by Maik Qualmann.
Committed on 04/11/2018 at 15:35.
Pushed by mqualmann into branch 'master'.

final step to disable unneeded action in the trash view
Related: bug 387319
FIXED-IN: 6.0.0

M  +2    -1    NEWS
M  +12   -1    core/app/main/digikamapp.cpp

https://commits.kde.org/digikam/a1c00c61a6558f041a8dc4bcf9e10ee669d55865