Bug 400424 - Star icon missing from download button
Summary: Star icon missing from download button
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_sddm (show other bugs)
Version: 5.14.2
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-28 16:00 UTC by retired
Modified: 2018-10-28 22:50 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.15.0
Sentry Crash Report:


Attachments
further explanation (8.34 KB, image/jpeg)
2018-10-28 16:00 UTC, retired
Details

Note You need to log in before you can comment on or make changes to this bug.
Description retired 2018-10-28 16:00:18 UTC
Created attachment 115949 [details]
further explanation

SUMMARY

All kcms that provide store.kde.org integration have star icon on download button. SDDM kcm seems to be missing that detail.

SOFTWARE VERSIONS
(available in About System)
KDE Plasma Version: 5.14.2
KDE Frameworks Version: 5.51.0
Qt Version: 5.11.2

Locale set to pl_PL, also tested with en_US just to make sure it's not problem with locale.
Comment 1 Nate Graham 2018-10-28 21:38:30 UTC
Here's a patch: https://phabricator.kde.org/D16497
Comment 2 Nate Graham 2018-10-28 22:50:10 UTC
Git commit de088bdca917e833176e9beff7407b47ffed8e58 by Nate Graham.
Committed on 28/10/2018 at 22:49.
Pushed by ngraham into branch 'master'.

Give the GHNS button an appropriate icon and more consistent text

Summary:
This patch gives the GHNS button an icon and tweaks its text to be consistent with the general pattern seen in other KCMs.
FIXED-IN: 5.15.0

Test Plan: {F6371684}

Reviewers: #plasma, #vdg, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D16497

M  +4    -1    src/ui/themeconfig.ui

https://commits.kde.org/sddm-kcm/de088bdca917e833176e9beff7407b47ffed8e58