Bug 400355 - When viewing a KCM with a tabbed view in kcmshell5, the window should update its size when switching between tabs to account for differing height of tabbed views
Summary: When viewing a KCM with a tabbed view in kcmshell5, the window should update ...
Alias: None
Product: frameworks-kcmutils
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.51.0
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdelibs bugs
Keywords: usability
Depends on:
Reported: 2018-10-27 06:24 UTC by trmdi
Modified: 2019-03-30 19:31 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.16.0

Activation tab (41.49 KB, image/png)
2018-10-27 08:13 UTC, Noah Davis
Appearance tab (144.93 KB, image/png)
2018-10-27 08:14 UTC, Noah Davis

Note You need to log in before you can comment on or make changes to this bug.
Description trmdi 2018-10-27 06:24:39 UTC
Window size need to be updated when switching between tabs

1. Open Screen Locking module from: Alt+F2 > Screen Locking
2. Switch from tab Activation to Appearance

Window size for tab Activation is OK. But when users switch to tab Appearance, the height is so small that the thumbnail area is hidden.

User can see the thumbnail area without having to resize the window.
(and when users switch back to tab Activation, it should update the window size again)

(available in About System)
KDE Plasma Version: 5.14.1
KDE Frameworks Version: 5.51.0
Qt Version: 5.11.2

Screenshot: https://i.imgur.com/5qP4DPS.png
Comment 1 Noah Davis 2018-10-27 07:39:42 UTC
The issue doesn't seem to be a result of switch tabs. To me, these are the issues:

- Default window size isn't large enough
- Maybe: The whole area under the tab needs to be scrollable so that users can scroll down to the wallpapers without resizing.
Comment 2 trmdi 2018-10-27 07:45:12 UTC
The window size is OK for the initial tab.
Comment 3 Noah Davis 2018-10-27 07:56:23 UTC
(In reply to trmdi from comment #2)
> The window size is OK for the initial tab.

Oh now I see what you were saying. You're saying it should to automatically resize when you change tabs, not that the issue is caused by changing tabs. I don't think the window should automatically resize because that could be jarring for muscle memory. Even if the default size is perfect for the first tab, I don't think it would hurt to increase the default size so that both tabs are usable at the default size.
Comment 4 trmdi 2018-10-27 08:01:35 UTC
But if that initial size is bigger, the initial tab will have too much empty space. Look ugly.
Comment 5 Noah Davis 2018-10-27 08:13:23 UTC
Created attachment 115917 [details]
Activation tab

It's a bit empty looking, but really not that bad.
Comment 6 Noah Davis 2018-10-27 08:14:00 UTC
Created attachment 115918 [details]
Appearance tab
Comment 7 trmdi 2018-10-27 08:26:41 UTC
Maybe. The initial size should depend on all tabs.
Comment 8 Nate Graham 2019-03-30 19:31:04 UTC
Git commit 35864f76ffe83b3fd1dea1aa24ec9c2f439088b2 by Nate Graham, on behalf of Tigran Gabrielyan.
Committed on 30/03/2019 at 19:30.
Pushed by ngraham into branch 'master'.

Fix window height of Screen Locking KCM

An implicitHeight must be set on QML components to prevent window size being too small.
FIXED-IN: 5.16.0

Test Plan:
  # Open Screen Locking settings
  # Go to Appearance tab
  # Two rows of thumbnails with labels should be shown


Reviewers: davidedmundson, ngraham

Reviewed By: davidedmundson, ngraham

Subscribers: ngraham, abetts, filipf, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D20086

M  +1    -0    kcm/wallpaperconfig.qml