SUMMARY Window size need to be updated when switching between tabs STEPS TO REPRODUCE 1. Open Screen Locking module from: Alt+F2 > Screen Locking 2. Switch from tab Activation to Appearance OBSERVED RESULT Window size for tab Activation is OK. But when users switch to tab Appearance, the height is so small that the thumbnail area is hidden. EXPECTED RESULT User can see the thumbnail area without having to resize the window. (and when users switch back to tab Activation, it should update the window size again) SOFTWARE VERSIONS (available in About System) KDE Plasma Version: 5.14.1 KDE Frameworks Version: 5.51.0 Qt Version: 5.11.2 ADDITIONAL INFORMATION Screenshot: https://i.imgur.com/5qP4DPS.png
The issue doesn't seem to be a result of switch tabs. To me, these are the issues: - Default window size isn't large enough - Maybe: The whole area under the tab needs to be scrollable so that users can scroll down to the wallpapers without resizing.
The window size is OK for the initial tab.
(In reply to trmdi from comment #2) > The window size is OK for the initial tab. Oh now I see what you were saying. You're saying it should to automatically resize when you change tabs, not that the issue is caused by changing tabs. I don't think the window should automatically resize because that could be jarring for muscle memory. Even if the default size is perfect for the first tab, I don't think it would hurt to increase the default size so that both tabs are usable at the default size.
But if that initial size is bigger, the initial tab will have too much empty space. Look ugly.
Created attachment 115917 [details] Activation tab It's a bit empty looking, but really not that bad.
Created attachment 115918 [details] Appearance tab
Maybe. The initial size should depend on all tabs.
Git commit 35864f76ffe83b3fd1dea1aa24ec9c2f439088b2 by Nate Graham, on behalf of Tigran Gabrielyan. Committed on 30/03/2019 at 19:30. Pushed by ngraham into branch 'master'. Fix window height of Screen Locking KCM Summary: An implicitHeight must be set on QML components to prevent window size being too small. FIXED-IN: 5.16.0 Test Plan: # Open Screen Locking settings # Go to Appearance tab # Two rows of thumbnails with labels should be shown {F6727233} Reviewers: davidedmundson, ngraham Reviewed By: davidedmundson, ngraham Subscribers: ngraham, abetts, filipf, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D20086 M +1 -0 kcm/wallpaperconfig.qml https://commits.kde.org/kscreenlocker/35864f76ffe83b3fd1dea1aa24ec9c2f439088b2